From nobody Tue Nov 26 10:48:51 2024 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XyK7S1r83z5fGj0 for ; Tue, 26 Nov 2024 10:48:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XyK7R18Lhz4v5N for ; Tue, 26 Nov 2024 10:48:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732618131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4EDiIwhb3mgyJvXVQKefhHP8eAsFCuUHV/eVPr/wI90=; b=pv0XxiZjIAMHO81KL02M5xyNBOPncT6A5bIey8Kt3EiFmAlBvDEVlcp0V/1g79SVjeekCp e84thXuomDw1f/+LfLqQQwsqzgxUVlD/5z3s7Ckx1soHAAUvcoqIL7jS4YQYMBBRHP4775 K3KfguVlHiykmmNLIa88xeF6BGQlEN2ToJvAmQv6o8Lk5que3OQqEOLRIu5bqyIDBQ+9Mb jpQS8fNOocIUgQC4EZfw+EznOsPDEKaJ+hqMILdRtb+OYjrRnXMSofIl/NPw5wNESn/Y6Q ga2CcXhXSI6G50XejJf2tU8Gd7oO7rljv9C9d+mmmiZAXieBTztjtdP0L3A1RA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732618131; a=rsa-sha256; cv=none; b=IZxgfJ4dM5c9P01I4shCuYePC0WPGxTom/uSue09UPP1lXAI8q7qWE3p0q+tcNETN9RTQH i/Wa+aWLtB4UZrYxHfYWhwVMKhlcKOEz+LTJP0EoECKvruf6HFCbRwUK3OpaoYUqmTHOKv p284eMMnW/VxyO2VkbHnkvI4mUHUC0JTr8vxLQEPH4qIu16T3vPdr3pPzrfnYCwNLYnVUw mZOO/2KKIlZCZRHCM7lRu+SDuycEpCUR58qfaRRA/ac0WbwA6WWReaX/UdWiDQhmP2hJvq +1Nb3ykbK49yE99JiscJPodZvwtUtgQNT5A1KpMCbsizCpP1SF2K6cYnpd+LVg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XyK7R0fYyzLmY for ; Tue, 26 Nov 2024 10:48:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 4AQAmonw024958 for ; Tue, 26 Nov 2024 10:48:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 4AQAmoeT024956 for bugs@FreeBSD.org; Tue, 26 Nov 2024 10:48:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 276709] hms(4): two finger scroll stops half way unless dev.hms.0.drift_thresh=0 Date: Tue, 26 Nov 2024 10:48:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 15.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D276709 --- Comment #4 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3Dc0a5ee953f41905038aadba7b7d0df2af= 6612e71 commit c0a5ee953f41905038aadba7b7d0df2af6612e71 Author: Edward Tomasz Napierala AuthorDate: 2024-11-25 15:08:10 +0000 Commit: Edward Tomasz Napierala CommitDate: 2024-11-26 10:28:51 +0000 hms(4): improve scroll with IICHID_SAMPLING The current quirk is designed to discard duplicated data read from the chip. Problem is, it also discards real events when they happen to be identical, which is the case with scroll wheel events; differently from X/Y they always move by fixed offset. This results in two-finger scroll that would stop mid-way that could be fixed by manually setting dev.hms.0.drift_thresh to 0. To fix that, don't discard duplicates when there's wheel movement. For users with actual duplicates problem this will result in scroll suddenly becoming quite inertial, but it will stop moving at any touch, so shouldn't be terrible. PR: kern/276709 Reviewed By: wulf Differential Revision: https://reviews.freebsd.org/D47640 sys/dev/hid/hms.c | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=