[Bug 269519] corrupt tar file can cause tarfs file system to panic or crash

In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 269519] corrupt tar file can cause tarfs file system to panic or crash"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 14 Feb 2023 13:24:11 UTC

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269519

Dag-Erling Smørgrav <des@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |In Progress

--- Comment #1 from Dag-Erling Smørgrav <des@FreeBSD.org> ---
This is easily fixed by removing the removing the assertion in
`tarfs_alloc_node()` and instead checking, at the top, that if `parent` is not
`NULL` then it is a directory, and returning an error if it isn't (which will
then be propagated out).  But part of me thinks this should have been caught by
`tarfs_lookup_path()` before we even got to `tarfs_alloc_node()`.

-- 
You are receiving this mail because:
You are the assignee for the bug.