From nobody Tue Feb 14 13:24:11 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PGMP736gPz3rxVL for ; Tue, 14 Feb 2023 13:24:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PGMP715qsz41D5 for ; Tue, 14 Feb 2023 13:24:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1676381051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YPE/oZF9H1+yo+7Fgi7GhNrBI08oPU3Uhe6Zfnu/8E0=; b=GA/Aqsq5FYgCKtzrCiSf8ukL7Dsd1wY7C4f+h6bI6nBphq1gYVlNZq4y9LxZtgv1OLetbb u6qpS5CZdLFAZzE/bhqoYPoRADdLEpgjJ3yS6K3nolEjvVHPgTXtZCG1YovqBcHuyIztRf E5hUFpszlVr2xSTcETs8w9WnleodpRnTIr6A+bV7PL2G3axNR0NXbpwtgbHcwsk6ekVLq/ Ycfz8ngbWP1ZBrzyafE2LFssy6A7QRkMe8/nJZqcXtoJd6vBdwcFY30EVcRY+lJEp9oIAL O6CKLEdqNHzaLYtlVOL4y5tIBDrjxoPaRdfbteEJ2E1k1eYji5agSNg+UB+Wsg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1676381051; a=rsa-sha256; cv=none; b=JRQiEqjL5w2Pv3Xte3W84DRV7FCe+90rEbGrTzNZ77aqTrGyCbBTFdLQO7TAoWB4/RJOj3 1Qhzk2hc46tZ5felux7b58q9Jj0WYwGj34+DcIiJFBn1AOoLkETMel8O/49iZAhk4DMFIP DgSCmulOIkmCDaGi1B4Ti4XNbrn6WGpZE9o1x4AsKW7WkpibwNl7UATQ3WkwP8B/KebJ4r uweru6YwGmj/6NN0obUCLOE6GzBUY3lMzbRBqOTpF3GSTzhFLR1hIWKNTp89nsD6mxR93L YJt0pzYZ/T9YmVkQsN4aALwD8T6PyptTDCUH+lmhg7Hq8KvpT0ehGZiFfDGL2g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PGMP70976z10Vk for ; Tue, 14 Feb 2023 13:24:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 31EDOAVq045375 for ; Tue, 14 Feb 2023 13:24:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 31EDOACQ045374 for bugs@FreeBSD.org; Tue, 14 Feb 2023 13:24:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 269519] corrupt tar file can cause tarfs file system to panic or crash Date: Tue, 14 Feb 2023 13:24:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: des@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269519 Dag-Erling Sm=C3=B8rgrav changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |In Progress --- Comment #1 from Dag-Erling Sm=C3=B8rgrav --- This is easily fixed by removing the removing the assertion in `tarfs_alloc_node()` and instead checking, at the top, that if `parent` is = not `NULL` then it is a directory, and returning an error if it isn't (which wi= ll then be propagated out). But part of me thinks this should have been caugh= t by `tarfs_lookup_path()` before we even got to `tarfs_alloc_node()`. --=20 You are receiving this mail because: You are the assignee for the bug.=