[Bug 267533] Zfs Multi-Modifier Protection trigger an activity check even if it is disabled
Date: Thu, 03 Nov 2022 18:41:16 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267533 --- Comment #2 from Mathieu Schmitt <firstname.lastname@example.org> --- Thanks for the answer :) So, the log : "> multihost activity detected txg 3144 ub_txg 3145 timestamp 1666367872 ub_timestamp 1666367903" is printed in the function in charge of performing the test. The modification - I suggested in the patch - takes place one step before, at the moment of evaluating if the activity check is required or not. Indeed, one check from the spa_activity_check_required function (with comment "Skip the activity check when the MMP feature is disabled", see: https://cgit.freebsd.org/src/tree/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c?h=releng/12.3#n2521) failed because the MMP_MAGIC on 12.1 is not defined in the uberblock definition. Based on this, I suppose that we have to guarantee the default behavior (MMP = disabled by default) of the feature even if this feature does not exist in 12.1, when we are upgrading from 12.1 to 12.3. -- You are receiving this mail because: You are the assignee for the bug.