From nobody Thu Nov 03 18:41:16 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4N3CJY0T3wz4gPVN for ; Thu, 3 Nov 2022 18:41:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4N3CJX5qypz461v for ; Thu, 3 Nov 2022 18:41:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4N3CJX4vfTzmXl for ; Thu, 3 Nov 2022 18:41:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 2A3IfGxD056837 for ; Thu, 3 Nov 2022 18:41:16 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 2A3IfGjg056836 for bugs@FreeBSD.org; Thu, 3 Nov 2022 18:41:16 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 267533] Zfs Multi-Modifier Protection trigger an activity check even if it is disabled Date: Thu, 03 Nov 2022 18:41:16 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mathieu.schmitt57@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1667500876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jNt7DSjAqs1qw7BbWZD4WOrV+RES9ykHioJemwR3Pm4=; b=THrzxHLGG85V4DJxyxVQSTDTjWVJf/OZf/JbZDzdbGScX1cjlNG5p8GWmpm/8fErRnoYHq xXXgmvHnlSFc77KvlMfLlLHgpgjb3Zr603nr4fs/3VvZVVJqnQWayTe35QPoA6oJv+xPh6 +kI31p6Uh8x2yj1osCznykaAesPskuOhpUG3TXNTmPglY4UKKukkKlIMZanwTS/Z/aqQEB ikUN7ZGODk35fnIgv685e0LDWIitvk2tA0pKznJRs5eepahcBy0iyqRp6nTq3S3A88GTyX +rNTiFqSdOUISVUlibrXIbB63oQ0Egpb0AjDQFcaJAA/0IC1qL87FssVST87CA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1667500876; a=rsa-sha256; cv=none; b=NnBHzPR6ZJ6+2fKUALnfl/VBc98lp+tCuj8a8YDG1Q9NrU2LuY/xeLoV1E34Nn+w7pElK8 TAL4XSeZQrSb2a4RjY/Up4S4RxOtpBgN5NSeAg7EdzADcqnaoNI28t/CKL96Q9M1zpvbd4 Ly5bKbWvlXhHZzeP+mpahFeTJTxJXaSi8FKBlilG1xtX8TQCFJFDXySthAq3prZxqeZqhZ bP2JEASSBj67rSr1ZRtn8sKLzmD1UyF2se/S88v4zzvZG3pCG5TYsYpvLJ1S1KEqyxH/bb m6XskG1kAY3tBYdpoNX/lgUHBthJUw3RmWTUyCwnTU8B3W5gQjpmNnPbLxKZMw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267533 --- Comment #2 from Mathieu Schmitt --- Thanks for the answer :) So, the log : "> multihost activity detected txg 3144 ub_txg 3145 timestamp 1666367872 ub_timestamp 1666367903" is printed in the function in charge of performing the test. The modification - I suggested in the patch - takes place one step before, = at the moment of evaluating if the activity check is required or not.=20 Indeed, one check from the spa_activity_check_required function (with comme= nt "Skip the activity check when the MMP feature is disabled", see: https://cgit.freebsd.org/src/tree/sys/cddl/contrib/opensolaris/uts/common/f= s/zfs/spa.c?h=3Dreleng/12.3#n2521) failed because the MMP_MAGIC on 12.1 is not defined in the uberblock definition. Based on this, I suppose that we have to guarantee the default behavior (MM= P =3D disabled by default) of the feature even if this feature does not exist in 12.1, when we are upgrading from 12.1 to 12.3. --=20 You are receiving this mail because: You are the assignee for the bug.=