[Bug 264578] release/tools/vmimage.subr has no error handling for pkg failures

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264578

--- Comment #3 from Ed Maste <emaste@freebsd.org> ---
This patch catches the error:

> Package textproc/jq installation failed

however release/scripts/mk-vmimage.sh does not check for errors from
vm_extra_install_packages, so it carries on anyway:

---
Package textproc/jq installation failed
umount: /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev: not a
file system root directory
umount: /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev: not a
file system root directory
umount: /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev: not a
file system root directory
umount: /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev: not a
file system root directory
umount: /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev: not a
file system root directory
umount: /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev: not a
file system root directory
umount: /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev: not a
file system root directory
umount: /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev: not a
file system root directory
umount: /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev: not a
file system root directory
umount: /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev: not a
file system root directory
Cannot umount(8) /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/dev
Something has gone horribly wrong.
/tmp/cirrus-ci-build/release/scripts/mk-vmimage.sh: cannot create
/usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/cw-oci/usr/local/etc/cloud/cloud.cfg.d/98_oci.cfg:
No such file or directory
Creating image...  Please wait.

Creating `/tmp/efiboot.kjHJWm'
/tmp/efiboot.kjHJWm: 65528 sectors in 65528 FAT32 clusters (512 bytes/cluster)
BytesPerSec=512 SecPerClust=1 ResSectors=32 FATs=2 Media=0xf0 SecPerTrack=63
Heads=255 HiddenSecs=0 HugeSectors=66584 FATsecs=512 RootCluster=2 FSInfo=1
Backup=2
Populating `/tmp/efiboot.kjHJWm'
Image `/tmp/efiboot.kjHJWm' complete
Building filesystem...  Please wait.
Calculated size of
`/usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/oci.img': 5368709120 bytes,
25952 inodes
Extent size set to 32768
density reduced from 206871 to 8192
/usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/oci.img: 5120.0MB (10485760
sectors) block size 32768, fragment size 4096
        using 9 cylinder groups of 626.31MB, 20042 blks, 80256 inodes.
super-block backups (for fsck -b #) at:
      192,  1282880,  2565568,  3848256,  5130944,  6413632,  7696320,
  8979008, 10261696,
Populating `/usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/oci.img'
Image `/usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/oci.img' complete
Building final disk image...  Please wait.
Disk image /usr/obj/tmp/cirrus-ci-build/arm64.aarch64/release/oci.qcow2
created.

-- 
You are receiving this mail because:
You are the assignee for the bug.