[Bug 264578] release/tools/vmimage.subr has no error handling for pkg failures

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264578

            Bug ID: 264578
           Summary: release/tools/vmimage.subr has no error handling for
                    pkg failures
           Product: Base System
           Version: 13.1-RELEASE
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: misc
          Assignee: bugs@FreeBSD.org
          Reporter: dch@freebsd.org

VM_EXTRA_PACKAGES is used in ec2.conf and gce.conf to
install packages into the chrooted build artefact.

When running pkg in chroot, if there are any errors, such
as packages that are not available, or the repo being
inaccessible, the build should fail here:

chroot ${DESTDIR} ${EMULATOR} env ASSUME_ALWAYS_YES=yes \
  /usr/sbin/pkg install -y ${VM_EXTRA_PACKAGES}

Currently, pkg return code is lost in the chroot.

These alternatives also swallow the return code:

pkg -o 'ABI=FreeBSD:13:amd64' --chroot ...
pkg -o ABI=FreeBSD:13:amd64 --rootdir ...

-- 
You are receiving this mail because:
You are the assignee for the bug.