[Bug 261377] mrsas: if controller reset is in progress, refrain from firing DCMDs to firmware from shutdown context

In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 261377] mrsas: Firing DCMDs while controller reset leads to firmware FMU error"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 05 Apr 2022 14:23:14 UTC

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261377

Warner Losh <imp@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |imp@FreeBSD.org

--- Comment #2 from Warner Losh <imp@FreeBSD.org> ---
I think this patch is in error, though the error is likely mostly harmless.

mrsas_shutdown is a newbus routine, so it should not be returning FAIL, but an
errno from errno.h. FAIL happens to be 1, which EPERM which isn't quite right.
Other drivers in the tree, however, return 0 in similar circumstances.

Having said that, however, the return value is completely ignored, so this
mismatch isn't a problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.