From nobody Tue Apr 05 14:23:14 2022 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5740B1A8AE82 for ; Tue, 5 Apr 2022 14:23:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KXqcf03mrz4XjH for ; Tue, 5 Apr 2022 14:23:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id D7440317 for ; Tue, 5 Apr 2022 14:23:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 235ENDfn018208 for ; Tue, 5 Apr 2022 14:23:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 235ENDhs018207 for bugs@FreeBSD.org; Tue, 5 Apr 2022 14:23:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 261377] mrsas: if controller reset is in progress, refrain from firing DCMDs to firmware from shutdown context Date: Tue, 05 Apr 2022 14:23:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 13.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: imp@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649168594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9EE8zLAbQnV5ukDvifOX8iV5DAK4wC27PqUY+OugvTE=; b=foYFr9q4CIBDsLzHtXKnesrR3AhIOm0W7D4oMGJd+LcvWBzTrs3cHyGB5sKLIWN/AsJQ/W ZC4a6E1GSZG7tIlEeH6yDA6wE5U2APfUqS1N+0bse2ZwVsH6WC1Ps4ckqGV8NU2h2YwOcj 8jo6bHUkRsPy8FwdKop1qUc0Nzc476dZy1BZlcY/Qo17Y6QgA8INjRTCkoZN75HEFO/IoK wwPDYDYfncmfSnN7SluQaeSCBcH97FV3inAH2HNFWHMvWzeC6+xlNbgaetIYgg/RVQbyhC pSEKfQQAeyImfDuDbBThKejD/f9v26KeAYwWBPnWEMCjp+DJfGoVKPazIIL+/w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649168594; a=rsa-sha256; cv=none; b=wTeKGkn/36EX3N2LuYylSC+nXmtcEKkjVtszT/wBLPHaNXm680P4CvM5gUsUtU0R61tiFr vrrcYPJznkuRdhbHdAVQvm9NC3xSbg5OUq9X9oWsz1HUnU0T15KfaarV/2PC4bubX51G2A p2NvaJN1YA1DIQ8mjiViyBTigQwWU6hiRKh9Hj1KIdbVVeBhudCaWfOKUC1tWC7ent64sP KF7TquE8UhtrbGWBEZff3Rdb9fKoZGBeJWmJ3JWdMcpKchDhkmHTawL7r3/G/grQqx3iUh KeOUplfHULxSj77kLirPpSWYNoF+bMxR5TtQxOY0Mdtgp82ssAaY8DFUTKxP7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D261377 Warner Losh changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imp@FreeBSD.org --- Comment #2 from Warner Losh --- I think this patch is in error, though the error is likely mostly harmless. mrsas_shutdown is a newbus routine, so it should not be returning FAIL, but= an errno from errno.h. FAIL happens to be 1, which EPERM which isn't quite rig= ht. Other drivers in the tree, however, return 0 in similar circumstances. Having said that, however, the return value is completely ignored, so this mismatch isn't a problem. --=20 You are receiving this mail because: You are the assignee for the bug.=