[Bug 257033] top(1): Sort by PID broke in 13.0-RELEASE

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 07 Jul 2021 04:12:30 +0000
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=257033

Mark Millard <marklmi26-fbsd_at_yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marklmi26-fbsd_at_yahoo.com

--- Comment #2 from Mark Millard <marklmi26-fbsd_at_yahoo.com> ---
(In reply to Kevin Zheng from comment #0)

The change was not in top but in r340742
(svn time frame head):

QUOTE
Revision 340742 - Directory Listing 
Modified Wed Nov 21 18:56:15 2018 UTC (2 years, 7 months ago) by mjg
proc: implement pid hash locks and an iterator

forks, exits and waits are frequently stalled during poudriere -j 128 runs
due to killpg and process list exports performed for each package.

Both uses take the allproc lock. The latter case can be modified to iterate
over the hash with finer grained locking instead.

Reviewed by:    kib
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D17817
END QUOTE

Top was not adjusted to deal with the consequences. But bisecting
top itself will do any good finding the change that lead to the
behavioral difference.

There was a review for an update to top that was never adopted:

https://reviews.freebsd.org/D18658

-- 
You are receiving this mail because:
You are the assignee for the bug.
Received on Wed Jul 07 2021 - 04:12:30 UTC

Original text of this message