Re: Quartz64 (RK3566) clock driver and patches.

From: Emmanuel Vadot <manu_at_bidouilliste.com>
Date: Mon, 26 Jul 2021 19:50:37 +0200
On Sat, 24 Jul 2021 22:17:06 +0200
Emmanuel Vadot <manu_at_bidouilliste.com> wrote:

> On Sat, 24 Jul 2021 19:46:20 +0200
> Søren Schmidt <soren.schmidt_at_gmail.com> wrote:
> 
> > On 24 Jul 2021, at 13.56, Emmanuel Vadot <manu_at_bidouilliste.com <mailto:manu_at_bidouilliste.com>> wrote:
> > 
> > >> 
> > >> On Sat, 24 Jul 2021 13:26:07 +0200
> > >> Søren Schmidt <soren.schmidt_at_gmail.com <mailto:soren.schmidt_at_gmail.com>> wrote:
> > >> 
> > >>> Hi 
> > >>> 
> > >>> As promised, the clk driver I did for the RK3566 used on the Pine Quartz64 board:
> > >>> 
> > >>> https://people.freebsd.org/~sos/Q64/ <https://people.freebsd.org/~sos/Q64/> <https://people.freebsd.org/~sos/Q64/ <https://people.freebsd.org/~sos/Q64/>>
> > >>> 
> > >>> Included the buld script, kernel config and u-boot I have used to get there.
> > >> 
> > >> That will be much easier to review on phab, or even github PR or git
> > >> send-email, basically anything else that this raw diff.
> > >> 
> > 
> > So for your entertainment I just uploaded the patch to fabricator, however I dont see how that changes anything but the colors :)
> 
>  That will make me look more closely to the patches :)
> 
>  Thanks,
> 
> > 
> > --
> > Søren Schmidt
> > sos_at_deepcore.dk / sos_at_freebsd.org
> > "So much code to hack, so little time"
> > 
> > 
> > 
> 
> 
> -- 
> Emmanuel Vadot <manu_at_bidouilliste.com> <manu_at_freebsd.org>
> 

 I cannot add comment to the review :
You Shall Not Pass: D31299
You do not have permission to edit this object.

 Looks like you added a custom policy : "sos created this object with
edit policy "sos (Søren Schmidt)"."

 Please remove it and also if you could upload diff with more context
too.

-- 
Emmanuel Vadot <manu_at_bidouilliste.com> <manu_at_freebsd.org>
Received on Mon Jul 26 2021 - 17:50:37 UTC

Original text of this message