From nobody Mon Jul 26 17:50:37 2021 X-Original-To: freebsd-arm@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id BBA8012D1568 for ; Mon, 26 Jul 2021 17:50:47 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mail.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GYSBt09pFz4n56 for ; Mon, 26 Jul 2021 17:50:45 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1627321838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a2dSTkiMvXTArLeym/Bfjs7unklGqhSxc/oDhzWqX/4=; b=FlWZY1Fu8DUUwg0y4VXfg7QcDp0Fm8omBiL1vcA5Y/TCQa7B0P4lT+zNUHKoejYKC+RdbC Z9maUEoDtx5U1mzMPp2Wxk2/yh3gf3S2YTlKJJIP/+jNUan97e2F/cvM7BXv6v17bvpddl s+Jg/EqGifo+ipeU5tKFGmJKJ2CmW1A= Received: from skull.home.blih.net (lfbn-idf2-1-644-4.w86-247.abo.wanadoo.fr [86.247.100.4]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 14b45f56 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 26 Jul 2021 17:50:37 +0000 (UTC) Date: Mon, 26 Jul 2021 19:50:37 +0200 From: Emmanuel Vadot To: =?ISO-8859-1?Q?S=F8ren?= Schmidt , Free BSD Subject: Re: Quartz64 (RK3566) clock driver and patches. Message-Id: <20210726195037.59165880a49ef24d1cb89833@bidouilliste.com> In-Reply-To: <20210724221706.04662e3c723a2427fdca0f75@bidouilliste.com> References: <20210724135600.752789eaa83309c8ab256e1e@bidouilliste.com> <20210724221706.04662e3c723a2427fdca0f75@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Porting FreeBSD to ARM processors List-Archive: https://lists.freebsd.org/archives/freebsd-arm List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-arm@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4GYSBt09pFz4n56 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mx header.b=FlWZY1Fu; dmarc=pass (policy=none) header.from=bidouilliste.com; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.155.74 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [0.09 / 15.00]; RCVD_TLS_ALL(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mx]; FREEFALL_USER(0.00)[manu]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:212.83.155.74/32]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bidouilliste.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[bidouilliste.com,none]; NEURAL_SPAM_SHORT(0.59)[0.589]; FREEMAIL_TO(0.00)[gmail.com,freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:12876, ipnet:212.83.128.0/19, country:FR]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[freebsd-arm] X-ThisMailContainsUnwantedMimeParts: N On Sat, 24 Jul 2021 22:17:06 +0200 Emmanuel Vadot wrote: > On Sat, 24 Jul 2021 19:46:20 +0200 > S=F8ren Schmidt wrote: >=20 > > On 24 Jul 2021, at 13.56, Emmanuel Vadot > wrote: > >=20 > > >>=20 > > >> On Sat, 24 Jul 2021 13:26:07 +0200 > > >> S=F8ren Schmidt > wrote: > > >>=20 > > >>> Hi=20 > > >>>=20 > > >>> As promised, the clk driver I did for the RK3566 used on the Pine Q= uartz64 board: > > >>>=20 > > >>> https://people.freebsd.org/~sos/Q64/ > > > >>>=20 > > >>> Included the buld script, kernel config and u-boot I have used to g= et there. > > >>=20 > > >> That will be much easier to review on phab, or even github PR or git > > >> send-email, basically anything else that this raw diff. > > >>=20 > >=20 > > So for your entertainment I just uploaded the patch to fabricator, howe= ver I dont see how that changes anything but the colors :) >=20 > That will make me look more closely to the patches :) >=20 > Thanks, >=20 > >=20 > > -- > > S=F8ren Schmidt > > sos@deepcore.dk / sos@freebsd.org > > "So much code to hack, so little time" > >=20 > >=20 > >=20 >=20 >=20 > --=20 > Emmanuel Vadot >=20 I cannot add comment to the review : You Shall Not Pass: D31299 You do not have permission to edit this object. Looks like you added a custom policy : "sos created this object with edit policy "sos (S=F8ren Schmidt)"." Please remove it and also if you could upload diff with more context too. --=20 Emmanuel Vadot