Re: git: 398254f9999e - main - mbuf: simplify m_free

From: Gleb Smirnoff <glebius_at_freebsd.org>
Date: Mon, 12 Oct 2026 23:16:24 UTC
On Mon, Oct 12, 2026 at 11:09:27PM +0000, Andrew Gallatin wrote:
A> The branch main has been updated by gallatin:
A> 
A> URL: https://cgit.FreeBSD.org/src/commit/?id=398254f9999eb1af5f0842570111d584aaf8d01a
A> 
A> commit 398254f9999eb1af5f0842570111d584aaf8d01a
A> Author:     Andrew Gallatin <gallatin@FreeBSD.org>
A> AuthorDate: 2026-10-12 21:32:52 +0000
A> Commit:     Andrew Gallatin <gallatin@FreeBSD.org>
A> CommitDate: 2026-10-12 23:08:16 +0000
A> 
A>     mbuf: simplify m_free
A>     
A>     The check for  (M_PKTHDR|M_NOFREE) was added by np@ in
A>     "91d1b03d3617 Merge r254736 from user/np/cxl_tuning."
A>     in order to support a clever rx mode optimization used
A>     by cxgbe at the time.  That optimization was removed in
A>     46e1e307edb6 several years ago.  This check is otherwise
A>     unneeded and adds an extraneous test to every mbuf free,
A>     so let's remove it.
A>     
A>     Reviewed by: glebius, np

A race condition happened :(

https://reviews.freebsd.org/D60686

-- 
Gleb Smirnoff