From nobody Mon Oct 12 23:16:24 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j3YHv56t2z6vlhd; Mon, 12 Oct 2026 23:16:27 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j3YHv4J31z4Gg9; Mon, 12 Oct 2026 23:16:27 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791846987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2FTgdSPsx6ZH0V4R3eiDyOvE6/+OPqMQ7FtG84ZA/XQ=; b=ECHvZtq+k9EYf6fBJ0sQ0D0LOU9MYgPHgog1q59PY3WbioP7mDVDiipft9QqZuGEumSauH b5xXIT4ava8L+qV/osHBrBd9e98HMxWR5zx70sHZcfPpe9Rdf1ZWqv/7mLnOHoIabAW8g3 mNfvGorspyrhc++TS5f8FSPjjtN6HmBlDn4bk9KiAV8umrPbvNuNW1WyDct2GUYjS7ChkZ eq5bzu+SjZj9VGEdXP2jgun2KYjDyCc5jS/N7gqKpXFLi7cwVP6259V9w/s7qDDBML4GrR 8wFjZscC+mhMhhXfj5m6rdLxf1c12CzTgLEdaD9nfPNHN6m/q+SM7pEqe4cDIA== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791846987; b=V0rH8UGuQb0Na4w94+1THTttN16xn70xkMdZAFTrB6vg4y1d6uaGE48jDkSzCYC3K3Shjq bc46EGI3CKzOPCzlF++r4qmf+99wYHpyRO48/ylDYbR5KlJF+VPnIldHKrceOgPq1UwVrw dzIXdiuC9l76YHpuohEGwzBe4/5BN6KPXfCHviWN6YxrK4sb7nVSNXClfCBA7Jb+2JAByL hIkbGbMmnoEUW3EhOG1BtPmCjtI7DW3c1d6EfqSapVzxZ1vTsFMIiOrMskYFKn/nx4lYQs UZIsIO3x6SRosn/5la9Gvq36ri6NRwDcP7ZRMHrZkiiH8t6sPxXwL+mbceq+wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791846987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2FTgdSPsx6ZH0V4R3eiDyOvE6/+OPqMQ7FtG84ZA/XQ=; b=Wz53nd9CgBG+unoKM7VH0Kn6vWe8x9M4YcYZHH5GAEOvmoUir11Awh95GqMCQk3Zqzsu8m bB2sVvPh64+nbOEcGs+x6fWy+2xV3p8h0WYKuTityw6CM8+EZznHTJA7X75DQet3YxcEQJ oouA7i5GXyaXtKoDFyvN09xxuRhF83zE1yBVbPxQiVe3pP+hHqfKXrNhiYOhwolqs6nQhM Yo2NCC8LIxl8TmS88o/tllfwpvJwbm4JrYr+5oVUuq9iqaFiizV4MMnvQpsjPg7beK47hF i2KtTwX0wRNlvP2oA1jQ2/9YNAGvMfJlNHszKxeCBiLDUUHNab230wq/x+v3JQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4j3YHt6rlMzZSC; Mon, 12 Oct 2026 23:16:26 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Mon, 12 Oct 2026 16:16:24 -0700 From: Gleb Smirnoff To: Andrew Gallatin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 398254f9999e - main - mbuf: simplify m_free Message-ID: References: <6acd68a7.255f2.871d1c1@gitrepo.freebsd.org> List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: Commit messages for the main branch of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6acd68a7.255f2.871d1c1@gitrepo.freebsd.org> On Mon, Oct 12, 2026 at 11:09:27PM +0000, Andrew Gallatin wrote: A> The branch main has been updated by gallatin: A> A> URL: https://cgit.FreeBSD.org/src/commit/?id=398254f9999eb1af5f0842570111d584aaf8d01a A> A> commit 398254f9999eb1af5f0842570111d584aaf8d01a A> Author: Andrew Gallatin A> AuthorDate: 2026-10-12 21:32:52 +0000 A> Commit: Andrew Gallatin A> CommitDate: 2026-10-12 23:08:16 +0000 A> A> mbuf: simplify m_free A> A> The check for (M_PKTHDR|M_NOFREE) was added by np@ in A> "91d1b03d3617 Merge r254736 from user/np/cxl_tuning." A> in order to support a clever rx mode optimization used A> by cxgbe at the time. That optimization was removed in A> 46e1e307edb6 several years ago. This check is otherwise A> unneeded and adds an extraneous test to every mbuf free, A> so let's remove it. A> A> Reviewed by: glebius, np A race condition happened :( https://reviews.freebsd.org/D60686 -- Gleb Smirnoff