git: 6c3f2b8be268 - main - mgb: Correct TX interrupt bit
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 09 Oct 2026 19:22:16 UTC
The branch main has been updated by emaste:
URL: https://cgit.FreeBSD.org/src/commit/?id=6c3f2b8be268de075d60387158f2889140851725
commit 6c3f2b8be268de075d60387158f2889140851725
Author: Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2026-10-09 19:10:18 +0000
Commit: Ed Maste <emaste@FreeBSD.org>
CommitDate: 2026-10-09 19:20:56 +0000
mgb: Correct TX interrupt bit
The TX interrupt handler checked MGB_INTR_STS_RX(qidx) instead of
MGB_INTR_STS_TX(qidx) -- presumably a copy-paste issue.
Because the driver does not use TX interrupts so there was no actual
issue in practice.
Reviewed by: adrian
Sponsored by: The FreeBSD Foundation
Fixes: 8890ab7758b8 ("Introduce if_mgb driver for Microchip LAN743x PCIe NIC")
Differential Revision: https://reviews.freebsd.org/D60550
---
sys/dev/mgb/if_mgb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sys/dev/mgb/if_mgb.c b/sys/dev/mgb/if_mgb.c
index 53a69f480784..60f93bb0615d 100644
--- a/sys/dev/mgb/if_mgb.c
+++ b/sys/dev/mgb/if_mgb.c
@@ -800,7 +800,7 @@ mgb_admin_intr(void *xsc)
/* XXX: TX interrupts should not occur */
if ((intr_sts & MGB_INTR_STS_TX_ANY) != 0) {
for (qidx = 0; qidx < scctx->isc_ntxqsets; qidx++) {
- if ((intr_sts & MGB_INTR_STS_RX(qidx))) {
+ if ((intr_sts & MGB_INTR_STS_TX(qidx))) {
/* clear the interrupt sts and run handler */
CSR_WRITE_REG(sc, MGB_INTR_ENBL_CLR,
MGB_INTR_STS_TX(qidx));