From nobody Fri Oct 09 19:22:16 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4j1cF51315z6vwP3 for ; Fri, 09 Oct 2026 19:22:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4j1cF5010Kz3FVH for ; Fri, 09 Oct 2026 19:22:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791573737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r2eQuOguLBam1XXCxq2Nlbxp2+xu5HoZ9TJAGcJxQvg=; b=JCh75TO9Ze4ff1phbIOrgOO4lfHIkoli7993ITH3to9vdokKX4lmfuQMdRuJQnh6n1vjQL u2tiGpgDW+Z9+8suinzQnc1ziZAh2ZUIoo4TWsU5gKZeq82YC8XjOj28XN2ZY3yg2psl3o QoymbUcuOyHypRk/jbXO/J67rNZYse9hc94KbvySBtWhbhWAR6d1czaEB+Fr4FJB83RMGs BSQIncurAGvcnXneSJ67bLpiMjghXQoGI7jARZ5qzGczjJl6iWVEFdZSMnv2/Kxu/9N7JQ cJt7MijysIw3ir0CGtY+rTA5zeEbdLrwE2XJe3T9iP2VF9ifdaHhlWtIgQj0gg== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1791573737; b=sdANLNBAZUWbubiJGZzDX2ByD/7p7m5GegTTxrCts5if23HTl1f32vpP6x48Y7NyXSCS3Z 3T02UAh4lEXNHPOyUyRueFHLW3bJtNHGD63+5JqSqqW7bXG9Z6CVrOJEcTKVxebnSzJ4AM 30OAP8uayYGWcFs/XAUkTISJtVYej979n5EUfbYIw7wvJiPDfNv6m+hqZp0Af1nJAOY6X9 9vyDCHOPsuSurNM8ylDjx4R/aSqWZ8K97Q7/YUpSUVT6biXb/nda+o930ju59IMT0k+KVs BaLz1is8rf1VOMsgvW/5/ImhrdvQxmU3ZxFc69dSsaZiT50X8ne/a+EhGCnEzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1791573737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=r2eQuOguLBam1XXCxq2Nlbxp2+xu5HoZ9TJAGcJxQvg=; b=ExL75IbZi+pQoa8yfXIZbCVf9vdmlsHqEuWSpJ9DK0KNtu/UaBmK5GySXGCwqwZ2+M3S6A DRAn73/uktMW4oor2PBDJ65byDKRCGfU/kH+64CdgXeYgvrUvgTYdIfBY6A0+CWyiuQSdn e7jT5yTPye6CJ74Nq084jkKpppYLBwkA8CDvLdcWEyFSF1+gZfL01s37m5VYA1SrvJUPv4 2Tb6Vi7674sWEfw7gHTfh/50MMrp5aZjUvF8C8PHzv1b0IB+XmpXjOZD3bJ4Ecno+jnp6e XRZIr1mD531JH30LtC8XEZ8/EbekOruEvw6+3qxrPzu6ek0XW/woeShhg/FVDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4j1cF469gfzNNv for ; Fri, 09 Oct 2026 19:22:16 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26707 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 09 Oct 2026 19:22:16 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 6c3f2b8be268 - main - mgb: Correct TX interrupt bit List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6c3f2b8be268de075d60387158f2889140851725 Auto-Submitted: auto-generated Date: Fri, 09 Oct 2026 19:22:16 +0000 Message-Id: <6ac93ee8.26707.22316e93@gitrepo.freebsd.org> The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=6c3f2b8be268de075d60387158f2889140851725 commit 6c3f2b8be268de075d60387158f2889140851725 Author: Ed Maste AuthorDate: 2026-10-09 19:10:18 +0000 Commit: Ed Maste CommitDate: 2026-10-09 19:20:56 +0000 mgb: Correct TX interrupt bit The TX interrupt handler checked MGB_INTR_STS_RX(qidx) instead of MGB_INTR_STS_TX(qidx) -- presumably a copy-paste issue. Because the driver does not use TX interrupts so there was no actual issue in practice. Reviewed by: adrian Sponsored by: The FreeBSD Foundation Fixes: 8890ab7758b8 ("Introduce if_mgb driver for Microchip LAN743x PCIe NIC") Differential Revision: https://reviews.freebsd.org/D60550 --- sys/dev/mgb/if_mgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/mgb/if_mgb.c b/sys/dev/mgb/if_mgb.c index 53a69f480784..60f93bb0615d 100644 --- a/sys/dev/mgb/if_mgb.c +++ b/sys/dev/mgb/if_mgb.c @@ -800,7 +800,7 @@ mgb_admin_intr(void *xsc) /* XXX: TX interrupts should not occur */ if ((intr_sts & MGB_INTR_STS_TX_ANY) != 0) { for (qidx = 0; qidx < scctx->isc_ntxqsets; qidx++) { - if ((intr_sts & MGB_INTR_STS_RX(qidx))) { + if ((intr_sts & MGB_INTR_STS_TX(qidx))) { /* clear the interrupt sts and run handler */ CSR_WRITE_REG(sc, MGB_INTR_ENBL_CLR, MGB_INTR_STS_TX(qidx));