Re: git: 8de34a84224b - main - arm64/iommu: Add a missing close parenthesis
- In reply to: John Baldwin : "git: 8de34a84224b - main - arm64/iommu: Add a missing close parenthesis"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 19 May 2026 18:17:16 UTC
On 5/19/26 13:31, John Baldwin wrote:
> The branch main has been updated by jhb:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=8de34a84224b9a353bc0a9d6d3f95540b0e72707
>
> commit 8de34a84224b9a353bc0a9d6d3f95540b0e72707
> Author: John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2026-05-19 17:30:01 +0000
> Commit: John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2026-05-19 17:30:01 +0000
>
> arm64/iommu: Add a missing close parenthesis
>
> Fixes: 6dc813301a17 ("sys: Use is_pci_device instead of direct comparisons to devclasses")
> Sponsored by: Chelsio Communications
> ---
> sys/arm64/iommu/smmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sys/arm64/iommu/smmu.c b/sys/arm64/iommu/smmu.c
> index 265f1e56f892..2d34b9177ed7 100644
> --- a/sys/arm64/iommu/smmu.c
> +++ b/sys/arm64/iommu/smmu.c
> @@ -1861,7 +1861,7 @@ smmu_ctx_init(device_t dev, struct iommu_ctx *ioctx)
>
> smmu_init_ste(sc, domain->cd, ctx->sid, ctx->bypass);
>
> - if (is_pci_device((ctx->dev))
> + if (is_pci_device((ctx->dev)))
> if (iommu_is_buswide_ctx(iodom->iommu, pci_get_bus(ctx->dev)))
> smmu_set_buswide(dev, domain, ctx);
Oof, I had tested this on x86, but not compiled it on other arches. :( I have a tinderbox
running and will push any other fixes needed.
--
John Baldwin