From nobody Tue May 19 18:17:16 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gKjZ4721Nz6fZ2l; Tue, 19 May 2026 18:17:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gKjZ43pMyz3Vgd; Tue, 19 May 2026 18:17:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779214636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cKJwafeYso5W7OCmSlNibcIYD/+M6EATzrf4teGHZus=; b=FEr7xD+ceqEHeaIoesVAGqanuI8LoiCDOQKLk5zn92898CFfxm+So5PfPH1s9zD/i3T+eo dYfEK76V0IjElOVuWKZwdru2z7ageaM+AV6G7VFiTN8ftZ2WJgjQVOBflNjBySKzhTfncB T7BdMJx/jWB1w/2Wy0kOcfm9r+VOLhzFJZBhiORomZ1Vi9c6e26rP/rA/H+LwlR9Oezvmk EIzQctLzDZDPYroGfSakbLEPuuWxRO0MmPRV8qMQocndgedKwQiyHtcncNTXFitUcqp4I+ CtBwd90TCMzTEW1nrVahYrwlVPTATzBsi9PCL6Y1vBoM5yS7Zbd4MFa15QnzHQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1779214636; a=rsa-sha256; cv=none; b=fEimnA5OyfMJuPDR0Gh0VpfgFSJ1ZilWIayibMdEhXYlpMj+2GROFa9eAnOv5nOpib2+VD zszdmgEBiYcRUAWC3jcYfqiWnuOrj2Np1AZ2IAWf4ki1TU4J0c80jmlJQb6sWnu45namvu UnraIS9MMK0JKQmKFl//IP1dhskU9g3h+LqJOZ61pf7WMO3RRWrN3Y/5Fz5H9HDBxDcJKK 7OEsy10Wqb/peVT1myAqDob61t1bJZ2oxIlIj0bXCDjlwuRdWcsNL+L1tnvMyw1L7plqPA 5FRTmG5nz77YNSqfceaeCG4SkYxvrhyZYJ2KHdAB3ks/pEFokHTIfU+24UIN7A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1779214636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cKJwafeYso5W7OCmSlNibcIYD/+M6EATzrf4teGHZus=; b=BODZo7TIxnY9vx1NmkORDKUE00Yj5ZtESs534iBu4BhCyPDjyNK2VRFNNZ7VtrhcuvOD/q 32aKjsY4oRzYa5sw9f4ux2S2cF71CWSilZc5rZJqBa8AwPfrG/+iVvEyWbij/rv7o0X1wf HCzuYRYXbS1H/S/LgHFWUrWN9uYXpDWxCVi4052ADVBu0YHjkokIgAj/PnpSv9dqH3OCuN uNdoxjD+9/9DecCWMAwDUz2tw8vVgungoOv+R/uPfRYI6M9e7c7w55UYRcSm15/4qAhfXv D3usdrkvTsJBvsS+2JFwc3cT3HqvCzowc5yB2354/nUjPoItLC6OfeaO2WuzvQ== Received: from [IPV6:2601:5c0:4202:5670:a9b6:fdfa:b02f:7cfa] (unknown [IPv6:2601:5c0:4202:5670:a9b6:fdfa:b02f:7cfa]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gKjZ428s6zJjV; Tue, 19 May 2026 18:17:16 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <85eb3305-b58d-455c-9bc7-678c5ade6873@FreeBSD.org> Date: Tue, 19 May 2026 14:17:16 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 8de34a84224b - main - arm64/iommu: Add a missing close parenthesis Content-Language: en-US From: John Baldwin To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <6a0c9e81.216b6.23e17744@gitrepo.freebsd.org> In-Reply-To: <6a0c9e81.216b6.23e17744@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/19/26 13:31, John Baldwin wrote: > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=8de34a84224b9a353bc0a9d6d3f95540b0e72707 > > commit 8de34a84224b9a353bc0a9d6d3f95540b0e72707 > Author: John Baldwin > AuthorDate: 2026-05-19 17:30:01 +0000 > Commit: John Baldwin > CommitDate: 2026-05-19 17:30:01 +0000 > > arm64/iommu: Add a missing close parenthesis > > Fixes: 6dc813301a17 ("sys: Use is_pci_device instead of direct comparisons to devclasses") > Sponsored by: Chelsio Communications > --- > sys/arm64/iommu/smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/arm64/iommu/smmu.c b/sys/arm64/iommu/smmu.c > index 265f1e56f892..2d34b9177ed7 100644 > --- a/sys/arm64/iommu/smmu.c > +++ b/sys/arm64/iommu/smmu.c > @@ -1861,7 +1861,7 @@ smmu_ctx_init(device_t dev, struct iommu_ctx *ioctx) > > smmu_init_ste(sc, domain->cd, ctx->sid, ctx->bypass); > > - if (is_pci_device((ctx->dev)) > + if (is_pci_device((ctx->dev))) > if (iommu_is_buswide_ctx(iodom->iommu, pci_get_bus(ctx->dev))) > smmu_set_buswide(dev, domain, ctx); Oof, I had tested this on x86, but not compiled it on other arches. :( I have a tinderbox running and will push any other fixes needed. -- John Baldwin