git: ac1f48b4a7be - main - ntpd: Fix segfault when same IP on multiple interfaces

From: Cy Schubert <cy_at_FreeBSD.org>
Date: Fri, 21 Nov 2025 03:13:33 UTC
The branch main has been updated by cy:

URL: https://cgit.FreeBSD.org/src/commit/?id=ac1f48b4a7be104d222dea60f1da946fcb345fb1

commit ac1f48b4a7be104d222dea60f1da946fcb345fb1
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2025-11-21 00:16:04 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2025-11-21 00:28:25 +0000

    ntpd: Fix segfault when same IP on multiple interfaces
    
    Use the protype socket to obtain the IP address for an error message.
    Using the resultant socket address, a NULL because create_interface()
    had failed, results in SIGSEGV.
    
    To reproduce this bug,
    
    ifconfig bridge100 create
    ifconfig bridge100 10.10.10.10/24
    ifconfig bridge101 create
    ifconfig bridge101 10.10.10.10/24
    ntpd -n
    
    PR:             291119
    MFC after:      3 days
---
 contrib/ntp/ntpd/ntp_io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c
index 9c4f6c1553e3..97b85ee83e36 100644
--- a/contrib/ntp/ntpd/ntp_io.c
+++ b/contrib/ntp/ntpd/ntp_io.c
@@ -1923,7 +1923,7 @@ update_interfaces(
 
 			msyslog(LOG_ERR,
 				"cannot bind address %s",
-				stoa(&ep->sin));
+				stoa(&ep2->sin));
 		}
 		free(ep2);
 	}