From nobody Fri Nov 21 03:13:33 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dCKzy0g9mz6GP0Q for ; Fri, 21 Nov 2025 03:13:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dCKzx6qVqz3S3f for ; Fri, 21 Nov 2025 03:13:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763694814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ipM3RakCuXwKVLhFtAQaBS4+Gdg+bHK5uMNW76DgVs8=; b=KHtjGfazdzt3K30RHN+2nDY4NYVs/LyCZtGpGbpPQqUxc55ED3xxxtE0uFpJcv2YUJUv3Y g1jmWvku5mDWbzDr82A8ThF4zsKn6O1+rUfRLgvHDTxfjpNKoi0ViLA0P+gd/Q2Qut3qjM hcB/YOLGz4NLoAQx4HAIhvT1FNkByAPpRDyF4SheSobD8wiGpY4ACVapVrZDVRaq0CFaWe +N0//IthroznEhJx8Ga7UZwWQfRYDxKKmpxhkk5dyuoXubM0KCEj0jBkDkJKuBK5uXKFuJ U2mjA64DjkIy2rbTz3G1BlDqdMsCbccS8kOz3oENQ869ZfP4iLjpG7btCG1T6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1763694814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ipM3RakCuXwKVLhFtAQaBS4+Gdg+bHK5uMNW76DgVs8=; b=RSiOu+ed5Azg91yFpKYn9lecgxbEdAclShoEMvSOKHRknWWBQlMdNebNIasx9u2TaMRYzO e0C000rvb3/GSb6mCNYH+B8zeIhoNrN5PJqxPgQqjRAqeRxBZHYZpFOCCTZgNSqedgpq3e KoZUpkkwkubV7+Ix+C86y6Coom52CGiUJDOmoKvpc/tue3R/YDHq70gHvuXMzxwxqnKmvf 2F5M1Dp+pY163s6N3YVO/ssLxN8190hHhiwwVat0TAX2+JaXcoUekhVv0zlDU3MJDKXFy/ 7Bd5IoGgwFRgStKapGWZIh8tSSYZrkRd4H8GBrTJ1Wrd1HC0mVxXqCi2nSUEtA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1763694814; a=rsa-sha256; cv=none; b=Dm0NpKugVpY/luuFztlqtB0R5N4bXQuyhRoIvpqAWWlSYoqIRLZQjNMBEgk6MERmjRbMEt EvsazoeqElaLzfDsEGSbeP/4ysqOMAThXlVe1k4l1k8nsZhhn8/9yDq1Z7wj4N064bma9E m7509gsw4R40HzqmWLWbtjqCrdZSu6vJqvvtjQIG5d2psbjRHF7UifOmEyaZt40ILhiTgU mgELL1Di+knfhzEzRw3KoiSHmDaF4qLuYjM9GtwO6ACtqp/vTL8AkeDbg0iXC1qI7Twpxm LB4LqPkhnw81VHmQyjpOLxJ0L/8yzYoEwoQ/Y8fh/c/nQStbyonMKjtE4r06bQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dCKzx6Jg8zv6R for ; Fri, 21 Nov 2025 03:13:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2f3cc by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 21 Nov 2025 03:13:33 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Cy Schubert Subject: git: ac1f48b4a7be - main - ntpd: Fix segfault when same IP on multiple interfaces List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ac1f48b4a7be104d222dea60f1da946fcb345fb1 Auto-Submitted: auto-generated Date: Fri, 21 Nov 2025 03:13:33 +0000 Message-Id: <691fd8dd.2f3cc.57309b9d@gitrepo.freebsd.org> The branch main has been updated by cy: URL: https://cgit.FreeBSD.org/src/commit/?id=ac1f48b4a7be104d222dea60f1da946fcb345fb1 commit ac1f48b4a7be104d222dea60f1da946fcb345fb1 Author: Cy Schubert AuthorDate: 2025-11-21 00:16:04 +0000 Commit: Cy Schubert CommitDate: 2025-11-21 00:28:25 +0000 ntpd: Fix segfault when same IP on multiple interfaces Use the protype socket to obtain the IP address for an error message. Using the resultant socket address, a NULL because create_interface() had failed, results in SIGSEGV. To reproduce this bug, ifconfig bridge100 create ifconfig bridge100 10.10.10.10/24 ifconfig bridge101 create ifconfig bridge101 10.10.10.10/24 ntpd -n PR: 291119 MFC after: 3 days --- contrib/ntp/ntpd/ntp_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/ntp/ntpd/ntp_io.c b/contrib/ntp/ntpd/ntp_io.c index 9c4f6c1553e3..97b85ee83e36 100644 --- a/contrib/ntp/ntpd/ntp_io.c +++ b/contrib/ntp/ntpd/ntp_io.c @@ -1923,7 +1923,7 @@ update_interfaces( msyslog(LOG_ERR, "cannot bind address %s", - stoa(&ep->sin)); + stoa(&ep2->sin)); } free(ep2); }