Re: git: f1b9c1aafd84 - main - random: git'o in RANDOM_ENABLE_TPM

On Tue, Nov 11, 2025 at 02:46:39AM +0000, David E. O'Brien wrote:
> The branch main has been updated by obrien:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=f1b9c1aafd8496c5bfdbc2be57bcfecfe58f12a8
> 
> commit f1b9c1aafd8496c5bfdbc2be57bcfecfe58f12a8
> Author:     David E. O'Brien <obrien@FreeBSD.org>
> AuthorDate: 2025-11-11 02:37:28 +0000
> Commit:     David E. O'Brien <obrien@FreeBSD.org>
> CommitDate: 2025-11-11 02:46:31 +0000
> 
>     random: git'o in RANDOM_ENABLE_TPM
>     
>     Fixes:  3deb21f1a
> ---
>  sys/dev/tpm/tpm20.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sys/dev/tpm/tpm20.h b/sys/dev/tpm/tpm20.h
> index 7c2ccd30143a..b2cfcd4f25bd 100644
> --- a/sys/dev/tpm/tpm20.h
> +++ b/sys/dev/tpm/tpm20.h
> @@ -128,7 +128,7 @@ struct tpm_sc {
>  	lwpid_t		owner_tid;
>  
>  	struct callout 	discard_buffer_callout;
> -#ifdef TPM_HARVEST
> +#if defined TPM_HARVEST || defined RANDOM_ENABLE_TPM

All the examples that use `#if defined...` in the style(9) manual page
show using parenthesis, though I'm not sure that equates to a style(9)
rule. It seems awkward here not to use parenthesis when they are used
(nearly?) everywhere else.

Is this something that warrants clarification in style(9)?

Thanks,

-- 
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

Signal Username:  shawn_webb.74
Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50
https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc