From nobody Tue Nov 11 15:40:43 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4d5W2m2nyWz6Gch5 for ; Tue, 11 Nov 2025 15:40:48 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4d5W2l5WTDz3TJv for ; Tue, 11 Nov 2025 15:40:47 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-94880628ffaso24420239f.0 for ; Tue, 11 Nov 2025 07:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1762875645; x=1763480445; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0h7GHGnhRsHBxSIc9M1T+vNlb33clJw5Cejnatc0obE=; b=jQkwHTqejASh3d0f4NyrKTtlwUNT+qML7JFkLMMf4GV8JGeu9ymob7VtvF93L1zo0w odpYpRbB6z1HDPJA2JA9ee9Jw+8Hiqm3Gp/s8korER6zt6gxOj2AcKzfBjjxyJorziug pnXhL7POrIHa75oPXqBXcGugnJUsQyZHgUiyr6TxlMfuFLHrwUNrDHZkKGn7cTATLb75 oywwt5UvVrlbq79EAdLUCoU5OPAec4nbmifSG+qIqlB0jhXvoblg3TIJl7skA5SBuxA2 HHgoGlYRq0U17F2fRd51P0YCKFMEq8D7JzKndVlfTrd6x0k3Qn/lzcutfb0qdY4hpTK6 B+zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762875645; x=1763480445; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0h7GHGnhRsHBxSIc9M1T+vNlb33clJw5Cejnatc0obE=; b=WSh/+Z+cG2Flf0rWQS8lqw3L+3RWphmsSAotCLLjs+6/7o0gVW/Z2L3jskzhcs6AP7 zx+1pFw6IAKDxXfncAca2830NORwSIoJVo/S0i0Ry5JPVR8cJ9uhUcIysdDTMb0WY512 v36apkHVwNCZurOjlflSPMhIm+cJAHGpwHjttTHIe/mSa6b6ge2ZxwECvPaGNpmFSTn6 fW6KKFN7XLZCW8EUa7hmXsFNRby1mc/ogiuZ+eTK/WXnex3k41hL+c4HMAzhRnDObQAI pptXOlmOuyQjcEPPhz6cAVzZHdW+Gcerlp5ROEzTrOfnPdvcNfD2RgprLpUE11mEXY8R 3GoQ== X-Forwarded-Encrypted: i=1; AJvYcCUXMlm18FyqJU1QKZZ8/EkYvxeobuzxtbO6645Py+gQl/Fh6g+bwK68F+9JKWo82ndvBZjd53e/XcvkIBdKXikSNeiTeA==@freebsd.org X-Gm-Message-State: AOJu0YxvEpx9Mkvv9oJdCeEGVL8Muk3ixvj4Yd2fhjt3DlRAeyqGDpM2 1qPiYLsMdCNwraHtdTy6GEVmSN0GDR+XkLxUom9dGOAIlh8iDhaUASmtPDLt4HQsrUE= X-Gm-Gg: ASbGncttn6ktSozGgQ06ioA3xaQShCNN3TLSZ4RkeKUTH30OzHnjwv1vb+WS6zIdjTu KJ0LEdJLvVTDPsnBL073m4jrvniywma5/0vJHpySj6uC+flolq1Lg2S0dKAp/kVHi0WPknJvR/7 C+jwn9yHmO3icFu75NHcQ1ogdsW5AHLX8CyOP3zukMFkCETQf3Wes1PPhsRmP57mSxfWta2pGyx rTXAi4axMUsorxjLMktqy7rqANBY80bX2wuK3qU4OWB3v4FAU4EapbxDTupJnavb1TUv9+BTL8R cHeK9C8Gt1mF/34W4HyAXrTKSZ3/c6+9S/mazgK+uaYcoIA27ZQxe1uLo94xQGyugrq9I5jVXBx EiFHnLzGaVseWZdz+BRyw8prjMY7fO/hyFqmiMqj9BRZyfZc2lsmkwPYLjg== X-Google-Smtp-Source: AGHT+IEpLmOCwdDws22GEwiyZRmvq4RFfppUedplpC6Gq/jrFFYwj126F1gO2SKRfASapVOrUWjyTQ== X-Received: by 2002:a92:ca8b:0:b0:433:7508:6a0d with SMTP id e9e14a558f8ab-4338bd8dc74mr41618995ab.0.1762875644717; Tue, 11 Nov 2025 07:40:44 -0800 (PST) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-5b7aaf59fb0sm6426173.13.2025.11.11.07.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Nov 2025 07:40:44 -0800 (PST) Date: Tue, 11 Nov 2025 15:40:43 +0000 From: Shawn Webb To: "David E. O'Brien" Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f1b9c1aafd84 - main - random: git'o in RANDOM_ENABLE_TPM Message-ID: X-Operating-System: FreeBSD mutt-hbsd 14.3-STABLE-HBSD FreeBSD 14.3-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202511110246.5AB2kdQc077401@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sltrz4ndl67lnkqu" Content-Disposition: inline In-Reply-To: <202511110246.5AB2kdQc077401@gitrepo.freebsd.org> X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4d5W2l5WTDz3TJv --sltrz4ndl67lnkqu Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: f1b9c1aafd84 - main - random: git'o in RANDOM_ENABLE_TPM MIME-Version: 1.0 On Tue, Nov 11, 2025 at 02:46:39AM +0000, David E. O'Brien wrote: > The branch main has been updated by obrien: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3Df1b9c1aafd8496c5bfdbc2be57= bcfecfe58f12a8 >=20 > commit f1b9c1aafd8496c5bfdbc2be57bcfecfe58f12a8 > Author: David E. O'Brien > AuthorDate: 2025-11-11 02:37:28 +0000 > Commit: David E. O'Brien > CommitDate: 2025-11-11 02:46:31 +0000 >=20 > random: git'o in RANDOM_ENABLE_TPM > =20 > Fixes: 3deb21f1a > --- > sys/dev/tpm/tpm20.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sys/dev/tpm/tpm20.h b/sys/dev/tpm/tpm20.h > index 7c2ccd30143a..b2cfcd4f25bd 100644 > --- a/sys/dev/tpm/tpm20.h > +++ b/sys/dev/tpm/tpm20.h > @@ -128,7 +128,7 @@ struct tpm_sc { > lwpid_t owner_tid; > =20 > struct callout discard_buffer_callout; > -#ifdef TPM_HARVEST > +#if defined TPM_HARVEST || defined RANDOM_ENABLE_TPM All the examples that use `#if defined...` in the style(9) manual page show using parenthesis, though I'm not sure that equates to a style(9) rule. It seems awkward here not to use parenthesis when they are used (nearly?) everywhere else. Is this something that warrants clarification in style(9)? Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --sltrz4ndl67lnkqu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmkTWPQACgkQ/y5nonf4 4fpLgBAAoPcgYjx4Mq3t65bZiBseX/6usXXUcV+jxuGl0RajyEiMfb7d4AA2od4H gKQgUUCXdr6xZLf0Lj5bCbLhp7U58rN+jbqKNg/EZr9EgZVIenVQG/9F3M0Xwr7w 9Ut+7apldvDF73WEY9YVDtr80EPSVBcIPUqnZG6nrzEa+T1AT1mLamumUvyzK63D pX3vXB5tulFZ7xC2uRGguKNzGtYwZHRnT7schGR+utLlOdEUVb+Q4BWIsH59k7yN iQaBZxyUm55vdGuxSM0jawAKtAPKjgbyvMPXuvm9+x19n7r4gM6gJF1MZfODaAy/ N5Qhf+v9qb3RpUzsnAhl4auJ4F2x68OhXZ8ErHCIsW/2hawnPY0orfvAgliKobuL Y/xnC/fPaYq/u2SnLRQLfh3Hws8igV8nCr6DNsPSpcTYk/foeMaIyP1hwQdaziPN 5bdGpzvOq0KozBC64wZa9agfTiN6GZKx/S9JAnnUdiJG+CC/K+ri8LnTNMnNqTEt v03TsdtJypumhsrBQkbKM8/T7KmLdJ9vyV6XcN8KuP94f3cjhRtmRMbgrMAMPn7t nxxlHLXk+MyjbzrX6BF0A++HHjvU3JQUy57wG6Jbfh26Bylt2hY+WFi5A717CmFC gZGVHiUagIwoYHjs33W4pYvzHvSIfwQFRp/wAdGezojEaKQSZWs= =Srti -----END PGP SIGNATURE----- --sltrz4ndl67lnkqu--