Re: git: 7e51bc6cdd5c - main - pf: Introduce unhandled_af()
Date: Wed, 05 Mar 2025 16:43:27 UTC
On Tue, Mar 04, 2025 at 08:05:51AM +0000, Kristof Provost wrote:
K> The branch main has been updated by kp:
K>
K> URL: https://cgit.FreeBSD.org/src/commit/?id=7e51bc6cdd5c317109e25b0b64230d00d68dceb3
K>
K> commit 7e51bc6cdd5c317109e25b0b64230d00d68dceb3
K> Author: Kristof Provost <kp@FreeBSD.org>
K> AuthorDate: 2025-03-03 16:26:39 +0000
K> Commit: Kristof Provost <kp@FreeBSD.org>
K> CommitDate: 2025-03-04 08:05:37 +0000
K>
K> pf: Introduce unhandled_af()
K>
K> For cases where code conditionally does something based on an address family
K> and later assumes one of the paths was taken. This was initially just calls
K> to panic until guenther suggested a function to reduce the amount of strings
K> needed.
K>
K> This reduces the amount of noise with static analysers and acts as a sanity
K> check.
K>
K> ok guenther@ bluhm@
K>
K> Obtained from: OpenBSD, jsg <jsg@openbsd.org>, ba4138390b
K> Sponsored by: Rubicon Communications, LLC ("Netgate")
Heh, enum solves the problem at compilation time. I will try to revisit the review
that had this idea.
--
Gleb Smirnoff