From nobody Wed Mar 05 16:43:27 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z7JJy5J51z5qRPl; Wed, 05 Mar 2025 16:43:30 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z7JJy4n37z3tDW; Wed, 05 Mar 2025 16:43:30 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741193010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6uO8+wytqhyctHyrlMuqRmcsfIZfGpEGK2L3GfRoFY0=; b=NNmsxaD9CobuOg+T8L/j1P4hDP1mxx6NVN1MbCrX6zcUr+3iN9cblp3M7UcCu6BCZrz+4u YK6OazIoTDYu9OzWuqtbyRlFQuYMe5oIMtLGM+nT7AlsD4pWMTyS1jUTQ5rQ6JddS2Wj7T jpxJMyqY8xN1x7RW7TrkdeZ/ep3mvb1ghvKO7zQv9Lj16FR/2pU+SgQc/YgHJosYUpAQ8O rmh6DbNa3gJRJxHgJmd0X0EroxSHP3EfB2foEOBDlPDLK4zNf+IvEeKbjf3UsClw17+1IA RKiTiEhRqMvPhzdmmpA2r3att0KvKIWF9SRQ2J6YvdQZ4wxnzqLbhCjOI17zIQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1741193010; a=rsa-sha256; cv=none; b=VJsBUWQmgQK/bsv0xwH4FYEd2oj2FHMsBFxAtQVI5OR1xFYGHBoTnpFZCiiRbd+gIQEq9g zc8n+QPIyWnxW/puFntbvT1TK0wmbSujtUCg+tHhf/gCsmPHxLYn1bjyTH04u6G7+lm+Jn mKJXLzGqCaeO8Eo3KjJWichwv5dRPTSJFbSB8TfPlPpMKifMRpxie12i/6nru6xpffNi1f eREc8Hn4pFGiw7Xnr3oAv/zFkFH+sOGODOPXL6DRylVRXSCAtK1E0ZuFKdYpNRxRTncTBW N6L6qB2Aj/FLE7xgxWXOnmE+plfrG2sRCeILn3dX5v3q+CKOlb5OrWappGNacw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1741193010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6uO8+wytqhyctHyrlMuqRmcsfIZfGpEGK2L3GfRoFY0=; b=AydOqG4swTyLDCHZkNYo4VzVEmBVQZEa+jl2gtZbgV2Bqum+EKoSfQZAsKUIvrovc82dWN PVemn5bCyU19rJRq1T1xn5JyxJvQApoOPf0HU0kOpH8xGi/DnrFTltVz6nka3JFIm8e6dY 4lAl8jjMSoct+VP+CyZS++mgZgsUCuWJX8/2C2FHSMabRjXWTGP2QmuifHIMr6L/KlYXtQ lwFaghKxYxCrU5XJDsTyZPFzMP2PHpOTCeKgrq8iUTguZKB2KMrZaX3140CkAf2nmv9tOG CtJnM1UOV63ZOmuxycyC/cbs2GGpu75Y/ftuHsGIBEt5Vajf6LCWns8eHkrTZA== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z7JJx6rTjz9Sk; Wed, 05 Mar 2025 16:43:29 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Wed, 5 Mar 2025 08:43:27 -0800 From: Gleb Smirnoff To: Kristof Provost Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7e51bc6cdd5c - main - pf: Introduce unhandled_af() Message-ID: References: <202503040805.52485pYn088632@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202503040805.52485pYn088632@gitrepo.freebsd.org> On Tue, Mar 04, 2025 at 08:05:51AM +0000, Kristof Provost wrote: K> The branch main has been updated by kp: K> K> URL: https://cgit.FreeBSD.org/src/commit/?id=7e51bc6cdd5c317109e25b0b64230d00d68dceb3 K> K> commit 7e51bc6cdd5c317109e25b0b64230d00d68dceb3 K> Author: Kristof Provost K> AuthorDate: 2025-03-03 16:26:39 +0000 K> Commit: Kristof Provost K> CommitDate: 2025-03-04 08:05:37 +0000 K> K> pf: Introduce unhandled_af() K> K> For cases where code conditionally does something based on an address family K> and later assumes one of the paths was taken. This was initially just calls K> to panic until guenther suggested a function to reduce the amount of strings K> needed. K> K> This reduces the amount of noise with static analysers and acts as a sanity K> check. K> K> ok guenther@ bluhm@ K> K> Obtained from: OpenBSD, jsg , ba4138390b K> Sponsored by: Rubicon Communications, LLC ("Netgate") Heh, enum solves the problem at compilation time. I will try to revisit the review that had this idea. -- Gleb Smirnoff