Re: git: f1f230439fa4 - main - vfs: Initial revision of inotify
- In reply to: Mark Johnston : "Re: git: f1f230439fa4 - main - vfs: Initial revision of inotify"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 13 Jul 2025 15:21:04 UTC
> The store to *eofp sets eofflag, so that is not the problem. Indeed, I missed that. Checking the rest of the function, I see no problem here. > Based on the presence of "efi" as a component name in the stack trace > that Charlie provided, I suspect the problem is rather in msdosfs, but I > don't immediately see what's wrong there. Based on that, I've just read msdosfs_readdir(), and the problem could be there: """ if (dep->de_FileSize - (offset - bias) <= 0) """ because dep->de_FileSize is an *unsigned* long, and the test only passes with 'offset - bias' exactly equal to 'de_FileSize'. The assignment to `diff` in the loop above would be wrong as well. -- Olivier Certner