From nobody Sun Jul 13 15:21:04 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bg8L20VByz616DW; Sun, 13 Jul 2025 15:21:14 +0000 (UTC) (envelope-from olce@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bg8L13RR0z3sM8; Sun, 13 Jul 2025 15:21:13 +0000 (UTC) (envelope-from olce@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752420073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DoJilKACp29ttkZe+IRyGzmhG+ybtTLn5PpQGLwM8RM=; b=wAhJU20ayUa/NEY2n1VsNJ1+b/Q16HSUeoZuTTlx7H2EroYj3QKG134DjttCk0bHW8knEQ oyxGtfchqFbn1pTC6Ju4q2Z0oaNrOb9RQd51sa8YxXg5C+BxR6Tkvs2qNg4AtMLcztghg6 Hpad6QKM+AJX92kZHlTVT4kzwoZIRrKk6la4mIeoJnyxsJSFZHYKekHGwkJe65G4zXF775 lTTe3LgIf46IdsqpJh10iB93BUMr6NYMGVzHPXtShZZhDN0PpEEBe9IlnYx5odMWecdyge ynCrY3UBS2flWbFr5TCAM46M5cDK7vg6mRNPG7bGe7h2OiPsrknfx7Tw/Ks9xQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752420073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DoJilKACp29ttkZe+IRyGzmhG+ybtTLn5PpQGLwM8RM=; b=isH4I4pxx1K2sPpcSs6mhza7bvoNnpEvO6NPXOeY9v2JWVrts4kRyNQKQLGyE4Ery08f/k JUsvn0PEzB56tH5jRXGURO0jGU1l2R1v2CuQuM1Jpun3h1qcYtjM9o14cVkrr98ZjKW8W8 JgIvpVa64FlyHuYM5FY8ZWYKdYKcEcETebaRAqVMX6wUWv4K/xLT/S1RGb02xYx2e2HQ+r ptxcJl31TAGxRTkKq9tnJoZF0EL9bTgX2F7k+G4lLM2dHyW9RGoHvDFF0fnusrDj+vAos8 7ALi5stweNL5rlvl7aifpClKvLPJfrOp753s3wu52xCp+gnPDFxphaNceZFL0Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752420073; a=rsa-sha256; cv=none; b=T7Ul0f/Ejqm94PDetT7o8txH1O+n3d7KEK+/lNz+kLbc5Ev/60uslocqoxSKqN8ba6gYSL B5BQMEMaOubZ+c5FA0z7CX3SyAcbK+6B6KYbl5+75zqpmrJBXKlAk0hzi+rqBAoSCBxIPl voS68J22HL0uJs1VkK+b82Ks9Pk99M2IivJ1IPtlocQFURDCgmivdknpHK7Jbj5JMK/HFk 17MiI3kGU/1Fd7XM3IQBObwEZCGvg7yA0fUAomikA7c5N8xXKWJnDjFPCtvpTqRL7la8MI 6lm+zvtQVp9eBdk2DH9ZBJxm+eh9DfkNL1gMmPcqlAuxUjQ9btWcoFeSwaRN/g== Received: from francois.localnet (h175-177-044-048.catv02.itscom.jp [175.177.44.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: olce/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4bg8Kz6SnyzBWg; Sun, 13 Jul 2025 15:21:11 +0000 (UTC) (envelope-from olce@freebsd.org) From: Olivier Certner To: Mark Johnston Cc: Charlie Li , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: f1f230439fa4 - main - vfs: Initial revision of inotify Date: Mon, 14 Jul 2025 00:21:04 +0900 Message-ID: <3224371.fEyhCgFcho@francois> Organization: FreeBSD In-Reply-To: References: <202507041455.564EtqwS073424@gitrepo.freebsd.org> <2937929.UcPf6a0QyJ@francois> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6956069.Qb2xPn7ZBO"; micalg="pgp-sha384"; protocol="application/pgp-signature" --nextPart6956069.Qb2xPn7ZBO Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Olivier Certner To: Mark Johnston Date: Mon, 14 Jul 2025 00:21:04 +0900 Message-ID: <3224371.fEyhCgFcho@francois> Organization: FreeBSD In-Reply-To: MIME-Version: 1.0 > The store to *eofp sets eofflag, so that is not the problem. Indeed, I missed that. Checking the rest of the function, I see no problem here. > Based on the presence of "efi" as a component name in the stack trace > that Charlie provided, I suspect the problem is rather in msdosfs, but I > don't immediately see what's wrong there. Based on that, I've just read msdosfs_readdir(), and the problem could be there: """ if (dep->de_FileSize - (offset - bias) <= 0) """ because dep->de_FileSize is an *unsigned* long, and the test only passes with 'offset - bias' exactly equal to 'de_FileSize'. The assignment to `diff` in the loop above would be wrong as well. -- Olivier Certner --nextPart6956069.Qb2xPn7ZBO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmhzzuAACgkQjKEwQJce Jid25g/6ArOIvsrLTJogChCET+ovk8EsjmnPbnWgxakceyV03KX3rJ0MauoTDV01 BghhwylQolKa5i/wBV89s2p92OMgf4mgP5OqDWUwOFJZDTtNHNvMkCjEs1BVcHcl BB107XkZy4tOba2yM1sWv8GtnRuV0OojK+Myq96iouq3bf1qQKH3Z3T7VDCeo8io 8TC0HzwH1nSyiefVMpJwCSa22FmycemytZhvMjS9TeB6EpaafS8HX/ftenxT683e tWX3sPmkXOeH5Ud9XS4UFTthwVJIRbs/JpziKXkCKS5/n/Xdo6siCdEaoqAVbqCj +DsQa9RLAU2nNOmqqoxmLpkQi7TD8vkjkvrXPgGeBkkh2uoKHbZwkeWeG05Jr4sC voKMzS0+yEbpxJfAo2mMcZLXnj1lu9LE5cKG2Z97E+babtDhwpz59mUg0dvi4Dv2 0//aJC5I+vyYoW9bFmZH2EK6BNGYNkBSRFPctNPywmMcpD5k+ym4PvMFJ+I6+ue8 l3xvdn/Rw67X68l62+lt1t84ttqlVo0Z5jGWmWfjvKH/eQcewsyPJ1mROlJjUoBJ jLHpzGwKpYfaUaLpW6jtsWy5qf5FjBpjaszjHGEUMItExePcwMKWFm+OEPnFcxvs yYMovlW8vrQrhx+awimdYKnIR028g/smNrf6x5vTlPXEcuwpv2A= =96JS -----END PGP SIGNATURE----- --nextPart6956069.Qb2xPn7ZBO--