Re: git: 0e58542fd246 - main - tcp: remove unused field from struct tcpcb

On Wed, 26 Feb 2025, Gleb Smirnoff wrote:

> On Wed, Feb 26, 2025 at 02:23:46AM +0000, Bjoern A. Zeeb wrote:
> B> > --- a/sys/netinet/tcp_var.h
> B> > +++ b/sys/netinet/tcp_var.h
> B> > @@ -452,7 +452,6 @@ struct tcpcb {
> B> > 	tcp_seq gput_seq;		/* Outbound measurement seq */
> B> > 	tcp_seq gput_ack;		/* Inbound measurement ack */
> B> > 	int32_t t_stats_gput_prev;	/* XXXLAS: Prev gput measurement */
> B> > -	uint32_t t_maxpeakrate;		/* max peak rate set by user, bytes/s */
> B>
> B> Is the tcpcb no longer KBI relevant these days?
> B> In the old days we'd simply make this a spare and not move all offsets
> B> below around.
>
> In the old days tcpcb was visible to userland, that's why there was
> the spare habit.

Yes, the problem really was with uitilities such as netstat.

But I see you solved that ages ago with struct xtcpcb which has tons
of spares to avoid that problem.

Sorry for the noise.
/bz

-- 
Bjoern A. Zeeb                                                     r15:7