From nobody Thu Feb 27 00:32:22 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Z3C3G4LmSz5pHwK; Thu, 27 Feb 2025 00:32:26 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Z3C3G3hntz3QPp; Thu, 27 Feb 2025 00:32:26 +0000 (UTC) (envelope-from bz@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740616346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NSi1RwBnMCoCVaVDviJXgmBW1fXREFT0snSTgJZ3ijg=; b=G6rZwQxuUF+LE7XMROkujeUpc2F0O2NJA5d2bxp0TAy2ATzzxJMMGwnrYQPcy22tu4Wn8a oU3sbfGATvB71JvkBGG+zfWEddzE6HHvGiA1yLJuFjon6aHFX92Pdn+p4fEvuhHPCCm4J1 nEh1i74aiiL2K2bl2gvw5+g/vhh4PmJESrg3gQvmOu8BaoGia+1ui00vjLCq38tmSCKzZy +nJV2IfKep/ZRZp6MyQTx/acXQftGY7cH8/PRHjWAkbdrjcpgFcEuttR3y9FwL7DrwV0EA p8h0JNBL08ryF1KisnuLzoQWraOg++uBMaHN7PxwWah+kgzTUluJazMSeysc4A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1740616346; a=rsa-sha256; cv=none; b=cOGdCJm9q0Apuzep32m0tbnZoEal3M0TuRY+JqDNZjZUZyCfZlyR4lMhIDg9hWH6c6UsD/ +fsGWyDoWaoI8s2WCGqphS9Oo5BGVeXRosacDDit16cxnrDRhbilqvlQmLScwZSxgLlhp6 PKuVeYoVZJw5MA8tULYFddct9Tut2FkcvafbMGndsUfUGA6G3vJJnpHZOaGQfVYRCn3nFx gCcWSRhZmPqTK2dQgQG7HcRNOt6BcOaDzMWXxoF2Tth3zx4fRIusXg+htk0TR04yZwgIWH jlIMEqFE2sR1kUfbmnVgbdL70Jnzcc5dmPh4E317c8Xr+j+a4R7e5+UUlYNO0A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1740616346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NSi1RwBnMCoCVaVDviJXgmBW1fXREFT0snSTgJZ3ijg=; b=Pvj/6GX24pusdLBHTT71UmIwY0VZOLJOakuzzAxryF2wkOW4ZksCIpyaTlXvHxSvEezHkJ T0l2cFMtq8Kea8mopDcsr8H1NyBQrP/90MKaLrkVpcEkE+yAMbmIOtp+vJA8ZVdUppyK1G 5eH7fcnoEjyB6ko9Ew5PmbOTAPGFpOBh4+Zhe6p9hSpOKp3Y603qLRMOqXp6wLRnrJtPzI fnNKwtTqPLkyp9EmJD7s1aZkmZ6KdSFWKRg79cegWyu0EwE6tlwac0C6uFhcBV/sN5w3Pu 7Ja/7rKV/4R2aeeTbhhFzQ8f0rm8VIzGbju1GAK2yg6qKH9Mb9+iroDZFmYGjQ== Received: from mx-01.divo.sbone.de (mx-01.divo.sbone.de [IPv6:2003:a:140a:2200:6:594:fffe:19]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (prime256v1) client-digest SHA256) (Client CN "mx-01.divo.sbone.de", Issuer "E5" (verified OK)) (Authenticated sender: bz/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Z3C3G27Dnz16Xy; Thu, 27 Feb 2025 00:32:26 +0000 (UTC) (envelope-from bz@freebsd.org) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mx-01.divo.sbone.de (Postfix) with ESMTPS id 144D9A64806; Thu, 27 Feb 2025 00:32:23 +0000 (UTC) Received: from content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 8070E2D029D8; Thu, 27 Feb 2025 00:32:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:4902:0:7404:2:1025]) by content-filter.t4-02.sbone.de (content-filter.t4-02.sbone.de [IPv6:fde9:577b:c1a9:4902:0:7404:2:2742]) (amavisd-new, port 10024) with ESMTP id yXwISqJBOk23; Thu, 27 Feb 2025 00:32:23 +0000 (UTC) Received: from strong-rtwn0.sbone.de (strong-rtwn0.sbone.de [IPv6:fde9:577b:c1a9:4902:da44:89ff:fedd:d5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id A7EE02D029E1; Thu, 27 Feb 2025 00:32:23 +0000 (UTC) Date: Thu, 27 Feb 2025 00:32:22 +0000 (UTC) From: "Bjoern A. Zeeb" To: Gleb Smirnoff cc: Michael Tuexen , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0e58542fd246 - main - tcp: remove unused field from struct tcpcb In-Reply-To: Message-ID: References: <202502252048.51PKm4YX061305@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Wed, 26 Feb 2025, Gleb Smirnoff wrote: > On Wed, Feb 26, 2025 at 02:23:46AM +0000, Bjoern A. Zeeb wrote: > B> > --- a/sys/netinet/tcp_var.h > B> > +++ b/sys/netinet/tcp_var.h > B> > @@ -452,7 +452,6 @@ struct tcpcb { > B> > tcp_seq gput_seq; /* Outbound measurement seq */ > B> > tcp_seq gput_ack; /* Inbound measurement ack */ > B> > int32_t t_stats_gput_prev; /* XXXLAS: Prev gput measurement */ > B> > - uint32_t t_maxpeakrate; /* max peak rate set by user, bytes/s */ > B> > B> Is the tcpcb no longer KBI relevant these days? > B> In the old days we'd simply make this a spare and not move all offsets > B> below around. > > In the old days tcpcb was visible to userland, that's why there was > the spare habit. Yes, the problem really was with uitilities such as netstat. But I see you solved that ages ago with struct xtcpcb which has tons of spares to avoid that problem. Sorry for the noise. /bz -- Bjoern A. Zeeb r15:7