git: a99b890ecd26 - main - linux(4): Drop a weird comment from linux_set_syscall_retval on amd64
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 28 May 2023 14:07:45 UTC
The branch main has been updated by dchagin:
URL: https://cgit.FreeBSD.org/src/commit/?id=a99b890ecd26131e0c91e5693b55f5700c40a847
commit a99b890ecd26131e0c91e5693b55f5700c40a847
Author: Dmitry Chagin <dchagin@FreeBSD.org>
AuthorDate: 2023-05-28 14:05:44 +0000
Commit: Dmitry Chagin <dchagin@FreeBSD.org>
CommitDate: 2023-05-28 14:05:44 +0000
linux(4): Drop a weird comment from linux_set_syscall_retval on amd64
I agree, it would be great to avoid PCB_FULL_IRET, however we should
follow Linux system call ABI.
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D40152
MFC after: 1 month
---
sys/amd64/linux/linux_sysvec.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sys/amd64/linux/linux_sysvec.c b/sys/amd64/linux/linux_sysvec.c
index 8e157f1ffb6b..916ab9b687bf 100644
--- a/sys/amd64/linux/linux_sysvec.c
+++ b/sys/amd64/linux/linux_sysvec.c
@@ -192,9 +192,6 @@ linux_set_syscall_retval(struct thread *td, int error)
* and %r11 values are not preserved across the syscall.
* Require full context restore to get all registers except
* those two restored at return to usermode.
- *
- * XXX: Would be great to be able to avoid PCB_FULL_IRET
- * for the error == 0 case.
*/
set_pcb_flags(td->td_pcb, PCB_FULL_IRET);
}