From nobody Sun May 28 14:07:45 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QTgTs3ZZKz4XR5d; Sun, 28 May 2023 14:07:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QTgTs36S8z4FWX; Sun, 28 May 2023 14:07:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685282865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UePCNvSfu1mKcy08vTJMseWMfNkVUsQ5m154fw0FiF4=; b=tPxcCuMoJjVJTxeGSE+Q4LbYXoEVjIDziCJ7l73pDD6rgZfo7WoAPC66r60L+h/qjor5fw Qbul5DU7qRxT1NPXlUfLVyJFwyXrXd5zNFdcR2InbPpr+5q9cqjSMuBe0UJciQFg8y30TJ vd+NdyWJX0CTSfjekfqgecEXxdaGWaae2kmY4Cw9zNK1+EnVgDBYxtk/IfWCVfeQFyGH8S AiGW6jF087k59FndNFxHWlBgCe0HtkS0eUaWYO8V3yiOOw5fJTu7plUuGukXD2tfDtx+MA NaKcTPmS7FO3wE5rFLWizZpylr61jX3OZ9fp4xh0Bpdr5UjiVQKMfenvkjNvFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685282865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=UePCNvSfu1mKcy08vTJMseWMfNkVUsQ5m154fw0FiF4=; b=UN6QikwD+GeZxsYQo5JMjqeii3zKHnA7yro1Ogg4aoiVeU1UbxLz4XF7C1/DNglrlanqOG 6dpkHzxYqX71w2hCeUwb7eE5WOV1jtoWoL2yDANvwgz+tDMDp2+ZKB7y5+zJ0fQuUA8s8z HeRxnYtawBeB3UzFqjWrTPp8vovv6P3VBMMZPwR8NflJqBSMWDbgvOfxg4WkFcEm3Uoxa6 0pm0Dk9q5yWuiWt1uIvwcv6j5fjzPn9gL25D/8eno4h9d7gZVNmDPMrQZVtPW0PdU98AD6 iOxDWdncbvyYsyddr3gPZHe0HYLiAclmQXYXEwsvwXDJfSuEOo/Ev+8ddDESeg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685282865; a=rsa-sha256; cv=none; b=dW4Srgsino5KIzTu8dpavYjPgDA/U+xddsrilU3HcuKGR7qY4PMoc4vzg1yD6bunGBoUgP pBcjf9coKMvQIDdYEbkVtB64JDrVVSlt+5MNf913zKbWxbRlkI7yYqTVrCJ85D60dz1MID xoHpfOCq7byElBpEMWgT7TGSyl99L5nJv5P6957FcX0/1uURO4yMegoqKrgI+JF3z8gZ+c TCDDU6xZJ2KG7Jj6ZOgoKO/a+lkH5kQRi2R0phjC8BqVnfq3tg0e1Loyf3RBDg6mMALpZ/ cg2ojbsWN8FiuViamQijN6BU5b9XIbNVlW4p7ye8T5N+k1NgL92MJn/oMvESfg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QTgTs29wszXx1; Sun, 28 May 2023 14:07:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 34SE7jLN067174; Sun, 28 May 2023 14:07:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 34SE7jR6067173; Sun, 28 May 2023 14:07:45 GMT (envelope-from git) Date: Sun, 28 May 2023 14:07:45 GMT Message-Id: <202305281407.34SE7jR6067173@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dmitry Chagin Subject: git: a99b890ecd26 - main - linux(4): Drop a weird comment from linux_set_syscall_retval on amd64 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dchagin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a99b890ecd26131e0c91e5693b55f5700c40a847 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=a99b890ecd26131e0c91e5693b55f5700c40a847 commit a99b890ecd26131e0c91e5693b55f5700c40a847 Author: Dmitry Chagin AuthorDate: 2023-05-28 14:05:44 +0000 Commit: Dmitry Chagin CommitDate: 2023-05-28 14:05:44 +0000 linux(4): Drop a weird comment from linux_set_syscall_retval on amd64 I agree, it would be great to avoid PCB_FULL_IRET, however we should follow Linux system call ABI. Reviewed by: emaste Differential Revision: https://reviews.freebsd.org/D40152 MFC after: 1 month --- sys/amd64/linux/linux_sysvec.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sys/amd64/linux/linux_sysvec.c b/sys/amd64/linux/linux_sysvec.c index 8e157f1ffb6b..916ab9b687bf 100644 --- a/sys/amd64/linux/linux_sysvec.c +++ b/sys/amd64/linux/linux_sysvec.c @@ -192,9 +192,6 @@ linux_set_syscall_retval(struct thread *td, int error) * and %r11 values are not preserved across the syscall. * Require full context restore to get all registers except * those two restored at return to usermode. - * - * XXX: Would be great to be able to avoid PCB_FULL_IRET - * for the error == 0 case. */ set_pcb_flags(td->td_pcb, PCB_FULL_IRET); }