git: 7388fb714a88 - main - cache: drop the vfs.cache_rename_add tunable

From: Mateusz Guzik <mjg_at_FreeBSD.org>
Date: Mon, 27 Jun 2022 07:56:41 UTC
The branch main has been updated by mjg:

URL: https://cgit.FreeBSD.org/src/commit/?id=7388fb714a88ed151c26efd737fd5b0779b4ee0d

commit 7388fb714a88ed151c26efd737fd5b0779b4ee0d
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2022-06-27 07:54:20 +0000
Commit:     Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2022-06-27 07:56:20 +0000

    cache: drop the vfs.cache_rename_add tunable
    
    The functionality has been in use since Jan 2021 -- long enough(tm).
---
 sys/kern/vfs_cache.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c
index 0b5913ef5eff..9e25d6f8fefb 100644
--- a/sys/kern/vfs_cache.c
+++ b/sys/kern/vfs_cache.c
@@ -445,10 +445,6 @@ static u_long __exclusive_cache_line	numcache;/* number of cache entries allocat
 
 struct nchstats	nchstats;		/* cache effectiveness statistics */
 
-static bool __read_mostly cache_rename_add = true;
-SYSCTL_BOOL(_vfs, OID_AUTO, cache_rename_add, CTLFLAG_RW,
-    &cache_rename_add, 0, "");
-
 static u_int __exclusive_cache_line neg_cycle;
 
 #define ncneghash	3
@@ -2964,9 +2960,7 @@ cache_vop_rename(struct vnode *fdvp, struct vnode *fvp, struct vnode *tdvp,
 	 * Recode this to reduce relocking and reuse the existing entry (if any)
 	 * instead of just removing it above and allocating a new one here.
 	 */
-	if (cache_rename_add) {
-		cache_enter(tdvp, fvp, tcnp);
-	}
+	cache_enter(tdvp, fvp, tcnp);
 }
 
 void