From nobody Mon Jun 27 07:56:41 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 639AC86FA31; Mon, 27 Jun 2022 07:56:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LWg6K2N5Bz4ZXd; Mon, 27 Jun 2022 07:56:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656316601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A04DvpMfjLWu/ZIVLEhrtFOpv94pT/7kt9bkuhK3INo=; b=H4VRnHEavQG9XRIZu/SnEBtykWUFpncj7pKN9T4NljIEPVzPAk97ebXVM4AniaKhSOmpR9 TYMzF5hhVJP2DoPtr93LZbq5PysQNokNRu2+yLj8Mreyoh4f1a+Zcyq3QY81lYRzSyRNKW n0dtl97Sj+AzcPowI+6Zg6BQvnDKdZbJTHrj1SbSawvmoN6tz750ee13ayQNER7Fyrl4Y1 5xueAEqJ3HhdyOBJCBMSy/zdGlBLSS0ce2xzWTpJCAaIXxsou1aNPv1pLxnuZJxR7cUp/I 7u92BkXwllronOZ8Y753NmNBggloxVlZF8tGHdyjO33JObYcYSXIu3LS6ksw/w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 2CB4F2456D; Mon, 27 Jun 2022 07:56:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 25R7ufG3064913; Mon, 27 Jun 2022 07:56:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 25R7ufcD064912; Mon, 27 Jun 2022 07:56:41 GMT (envelope-from git) Date: Mon, 27 Jun 2022 07:56:41 GMT Message-Id: <202206270756.25R7ufcD064912@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: 7388fb714a88 - main - cache: drop the vfs.cache_rename_add tunable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7388fb714a88ed151c26efd737fd5b0779b4ee0d Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1656316601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A04DvpMfjLWu/ZIVLEhrtFOpv94pT/7kt9bkuhK3INo=; b=BKUCfZIzDIS5d1wywOGq2wP9+cEGFxUdXP/fGL9mojOd+Ghto7Zt/+o2w/32kRG2Fyq33Y hPD2qQuBs0bQIIWmsORVtpfcnDDkt/o+Mxx9wBstOFCKM+ClU5Hw/ltljYfSiH7LOfSHFF z5FVW3/qIlNLncchvbC2f2BYV5KttZzv55QfBdLWwZ+dGTegbAZYaF/Tuy7JFS0Qrf6Pbq 8eLcoZ0qzh9xA1DRYDRevgsul1XO+9HqlxVPjXMzZpIiFID4utALSkosSI06vMGQCzNn0a 2el8KI1g4rcwKcySyaNA2rZT7OOyvFvsmBhhAJYMtdmWVHB8Um132dEXy27OsA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1656316601; a=rsa-sha256; cv=none; b=HL9LWAK3yfI9/wilwMCA2TwJQTnbKpsQo+jRBFPdmQwNtUHwuhxyOIy7NBF8FJGilvzWwK ZddKYrBVFiHxBMqIxy7AiTyoX+53iLUhfm6PyteFo0v8J4yz3M9eKuysc6BA0J2nD6COpi nqyHSXf7BYq7YN7ykzcDA10jWDrH0Kk/0HirO12lARNamjKhVq41PKoHwTrjlzCSu8/m02 GLbPiI7fTLV+gdypAUWH+PQxP6MTeInPoO5fQlcsMF6mdKY47NnycWfKruC3cGNtfE/9dE nWa54KcDfajYthxktAczXMgyYxWmUAX1snpIbKMPT7vsxARjQ9yNQuyV/d9Ocw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=7388fb714a88ed151c26efd737fd5b0779b4ee0d commit 7388fb714a88ed151c26efd737fd5b0779b4ee0d Author: Mateusz Guzik AuthorDate: 2022-06-27 07:54:20 +0000 Commit: Mateusz Guzik CommitDate: 2022-06-27 07:56:20 +0000 cache: drop the vfs.cache_rename_add tunable The functionality has been in use since Jan 2021 -- long enough(tm). --- sys/kern/vfs_cache.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c index 0b5913ef5eff..9e25d6f8fefb 100644 --- a/sys/kern/vfs_cache.c +++ b/sys/kern/vfs_cache.c @@ -445,10 +445,6 @@ static u_long __exclusive_cache_line numcache;/* number of cache entries allocat struct nchstats nchstats; /* cache effectiveness statistics */ -static bool __read_mostly cache_rename_add = true; -SYSCTL_BOOL(_vfs, OID_AUTO, cache_rename_add, CTLFLAG_RW, - &cache_rename_add, 0, ""); - static u_int __exclusive_cache_line neg_cycle; #define ncneghash 3 @@ -2964,9 +2960,7 @@ cache_vop_rename(struct vnode *fdvp, struct vnode *fvp, struct vnode *tdvp, * Recode this to reduce relocking and reuse the existing entry (if any) * instead of just removing it above and allocating a new one here. */ - if (cache_rename_add) { - cache_enter(tdvp, fvp, tcnp); - } + cache_enter(tdvp, fvp, tcnp); } void