Re: git: a46722b58056 - main - ncurses: register formw as usable lib for LIBADD

On Wed, 24 Nov 2021, Baptiste Daroussin wrote:

> On Wed, Nov 24, 2021 at 03:34:02PM +0000, Bjoern A. Zeeb wrote:
>> On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote:
>>
>>> On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote:
>>>
>>>> On Wed, 24 Nov 2021, Baptiste Daroussin wrote:
>>>>
>>>>> The branch main has been updated by bapt:
>>>>>
>>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=a46722b580567799b484b5a81728eaf380777e04
>>>>>
>>>>> commit a46722b580567799b484b5a81728eaf380777e04
>>>>> Author:     Baptiste Daroussin <bapt@FreeBSD.org>
>>>>> AuthorDate: 2021-11-24 09:20:10 +0000
>>>>> Commit:     Baptiste Daroussin <bapt@FreeBSD.org>
>>>>> CommitDate: 2021-11-24 10:02:22 +0000
>>>>>
>>>>>    ncurses: register formw as usable lib for LIBADD
>>>>
>>>> is LIBFORM to be LIBFORMW or do we need another new entry?
>>>>
>>>>   1393 make[7]: "share/mk/bsd.libnames.mk" line 190:
>>>> lib/ncurses/form: Missing value for LIBFORMW in bsd.libnames.mk.
>>>> Likely should be: LIBFORMW?= ${LIBDESTDIR}${LIBDIR_BASE}/libformw.a
>>>
>>>
>>> and later still:
>>>
>>>   6315 ld: error: unable to find library -lformw
>>>   6316 cc: error: linker command failed with exit code 1 (use -v to see
>>> invocation)
>>>   6317 --- libprivatebsddialog.so.0.full ---
>>>   6318 *** [libprivatebsddialog.so.0.full] Error code 1
>>>
>>>
>>> @ 848ee2a3a8b47c9905fc51fefcf60eb371edbb98
>>
>> I've locally fixed this (it seems) like this for now:
>>
>> diff --git a/Makefile.inc1 b/Makefile.inc1
>> index d8f50cf77d4b..620d9f239b6e 100644
>> --- a/Makefile.inc1
>> +++ b/Makefile.inc1
>> @@ -2943,6 +2943,7 @@ _prebuild_libs=   ${_kerberos5_lib_libasn1} \
>>                 ${_lib_casper} \
>>                 lib/ncurses/tinfo \
>>                 lib/ncurses/ncurses \
>> +               lib/ncurses/form \
>>                 lib/libopie lib/libpam/libpam lib/libthr \
>>                 ${_lib_libradius} lib/libsbuf lib/libtacplus \
>>                 lib/libgeom \
>> @@ -2982,6 +2983,7 @@ _lib_libradius=   lib/libradius
>>  .endif
>>
>>  lib/ncurses/ncurses__L:        lib/ncurses/tinfo__L
>> +lib/ncurses/form__L:   lib/ncurses/ncurses__L
>>
>>  .if ${MK_OFED} != "no"
>>  _prebuild_libs+= \
>>
>
> I think it should be fixed, I don't think it is necessary to add it to the
> prebuild_libs


I just saw it flying in;  thanks a lot!   I had just used a hammer.

-- 
Bjoern A. Zeeb                                                     r15:7