From nobody Wed Nov 24 15:51:03 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CF42418AE274; Wed, 24 Nov 2021 15:51:08 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hzlq04jgmz3NGN; Wed, 24 Nov 2021 15:51:08 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 5E5BE8D4A179; Wed, 24 Nov 2021 15:51:07 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id DF1EFE70847; Wed, 24 Nov 2021 15:51:06 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id vqYf-P7q5P6a; Wed, 24 Nov 2021 15:51:04 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 66CF9E70846; Wed, 24 Nov 2021 15:51:04 +0000 (UTC) Date: Wed, 24 Nov 2021 15:51:03 +0000 (UTC) From: "Bjoern A. Zeeb" To: Baptiste Daroussin cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a46722b58056 - main - ncurses: register formw as usable lib for LIBADD In-Reply-To: <20211124154950.iu62azibagbgosjh@aniel.nours.eu> Message-ID: References: <202111241003.1AOA3pxZ008905@gitrepo.freebsd.org> <20211124154950.iu62azibagbgosjh@aniel.nours.eu> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 4Hzlq04jgmz3NGN X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 24 Nov 2021, Baptiste Daroussin wrote: > On Wed, Nov 24, 2021 at 03:34:02PM +0000, Bjoern A. Zeeb wrote: >> On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote: >> >>> On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote: >>> >>>> On Wed, 24 Nov 2021, Baptiste Daroussin wrote: >>>> >>>>> The branch main has been updated by bapt: >>>>> >>>>> URL: https://cgit.FreeBSD.org/src/commit/?id=a46722b580567799b484b5a81728eaf380777e04 >>>>> >>>>> commit a46722b580567799b484b5a81728eaf380777e04 >>>>> Author: Baptiste Daroussin >>>>> AuthorDate: 2021-11-24 09:20:10 +0000 >>>>> Commit: Baptiste Daroussin >>>>> CommitDate: 2021-11-24 10:02:22 +0000 >>>>> >>>>> ncurses: register formw as usable lib for LIBADD >>>> >>>> is LIBFORM to be LIBFORMW or do we need another new entry? >>>> >>>> 1393 make[7]: "share/mk/bsd.libnames.mk" line 190: >>>> lib/ncurses/form: Missing value for LIBFORMW in bsd.libnames.mk. >>>> Likely should be: LIBFORMW?= ${LIBDESTDIR}${LIBDIR_BASE}/libformw.a >>> >>> >>> and later still: >>> >>> 6315 ld: error: unable to find library -lformw >>> 6316 cc: error: linker command failed with exit code 1 (use -v to see >>> invocation) >>> 6317 --- libprivatebsddialog.so.0.full --- >>> 6318 *** [libprivatebsddialog.so.0.full] Error code 1 >>> >>> >>> @ 848ee2a3a8b47c9905fc51fefcf60eb371edbb98 >> >> I've locally fixed this (it seems) like this for now: >> >> diff --git a/Makefile.inc1 b/Makefile.inc1 >> index d8f50cf77d4b..620d9f239b6e 100644 >> --- a/Makefile.inc1 >> +++ b/Makefile.inc1 >> @@ -2943,6 +2943,7 @@ _prebuild_libs= ${_kerberos5_lib_libasn1} \ >> ${_lib_casper} \ >> lib/ncurses/tinfo \ >> lib/ncurses/ncurses \ >> + lib/ncurses/form \ >> lib/libopie lib/libpam/libpam lib/libthr \ >> ${_lib_libradius} lib/libsbuf lib/libtacplus \ >> lib/libgeom \ >> @@ -2982,6 +2983,7 @@ _lib_libradius= lib/libradius >> .endif >> >> lib/ncurses/ncurses__L: lib/ncurses/tinfo__L >> +lib/ncurses/form__L: lib/ncurses/ncurses__L >> >> .if ${MK_OFED} != "no" >> _prebuild_libs+= \ >> > > I think it should be fixed, I don't think it is necessary to add it to the > prebuild_libs I just saw it flying in; thanks a lot! I had just used a hammer. -- Bjoern A. Zeeb r15:7