Re: git: 169e06fa7852 - main - os-release: Quote variables as documented in the manual

In reply to: Mateusz Piotrowski : "git: 169e06fa7852 - main - os-release: Quote variables as documented in the manual"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Mateusz Piotrowski <0mp_at_FreeBSD.org>
Date: Wed, 24 Nov 2021 15:30:24 UTC

On 24/11/2021 16:28, Mateusz Piotrowski wrote:
> The branch main has been updated by 0mp (doc, ports committer):
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=169e06fa7852810f4ced2cce7a3c14ca9443bf39
>
> commit 169e06fa7852810f4ced2cce7a3c14ca9443bf39
> Author:     Mateusz Piotrowski <0mp@FreeBSD.org>
> AuthorDate: 2021-11-23 10:26:47 +0000
> Commit:     Mateusz Piotrowski <0mp@FreeBSD.org>
> CommitDate: 2021-11-24 15:17:01 +0000
>
>      os-release: Quote variables as documented in the manual
>      
>      Variables must be quoted if they contain non-alphanumeric characters.
>      
>      Warner noted in the review that the lack of quoting causing problems
>      here is rather an edge case. I believe that it's worth adding the quotes
>      here anyway because this is what the specification says and there is no
>      good reason not to follow it.
>      
>      Reviewed by:    imp
>      Approved by:    imp (src)
>      MFC after:      7 days

Differential revision: https://reviews.freebsd.org/D33092