From nobody Wed Nov 24 15:30:24 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 477DB18A33C4 for ; Wed, 24 Nov 2021 15:30:35 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HzlMG0QsBz3CqF for ; Wed, 24 Nov 2021 15:30:34 +0000 (UTC) (envelope-from mpp302@gmail.com) Received: by mail-wr1-f41.google.com with SMTP id v11so4870817wrw.10 for ; Wed, 24 Nov 2021 07:30:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=3q2YQbiocSlwh2tSY56Aeqn5CQ5WEco/Yevt6gvjlQg=; b=VVfHOSlb151WD/xD2sRYdcqO4LHLDLIVZf2SOQmmX1r7nUevOw1h2GgfY8APNroOw/ OIt3fdE2GufzifDdhqz/z5nRGlmZxBoiglKlcjVUdYUZ7Lod+jg8OABcvlLDeY0ITmo3 NyT/Kgyzpbtqo7kTkolMd4/L++H+qsJrjhNHIAO3zfS88gViX8H/+9mMmzMLKUydEo/M kA00oYzrK/7QcUuDJeTIeadRL9dQ6Rh4zsQdTsGUrvrVj57YDilt1ceOYujf9pg61o7i mPM3bgDWo5ek0+zTzPR5qut+P0lhN90vUxGRwGmvpujVG+E4ScmIagZ/Mzqh1YE0d6P8 9R1Q== X-Gm-Message-State: AOAM530YmoA0cpv6jwhjTDs6eXBRbJfPqHoaYXENNrtfTjCPONaTN2xq Zyi+MOMFXvF86pUMs2z3//jHwIZhDgXY7A== X-Google-Smtp-Source: ABdhPJxzBrvECZCbqzCFuFApx6Au2YetFWOolX2Gy/g0c0fTQLHd//I/urxxB8+ZssAdNDj8HJQ1Bg== X-Received: by 2002:adf:a444:: with SMTP id e4mr18260208wra.341.1637767825358; Wed, 24 Nov 2021 07:30:25 -0800 (PST) Received: from [192.168.0.194] (ip5f5bf437.dynamic.kabel-deutschland.de. [95.91.244.55]) by smtp.gmail.com with ESMTPSA id 4sm179718wrz.90.2021.11.24.07.30.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Nov 2021 07:30:24 -0800 (PST) Message-ID: <3be1e343-c79a-27b5-3dde-bda2369dc322@FreeBSD.org> Date: Wed, 24 Nov 2021 16:30:24 +0100 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: git: 169e06fa7852 - main - os-release: Quote variables as documented in the manual Content-Language: en-US To: dev-commits-src-main@freebsd.org References: <202111241528.1AOFSJdf038653@gitrepo.freebsd.org> From: Mateusz Piotrowski <0mp@FreeBSD.org> In-Reply-To: <202111241528.1AOFSJdf038653@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4HzlMG0QsBz3CqF X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of mpp302@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=mpp302@gmail.com X-Spamd-Result: default: False [-0.82 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FORGED_SENDER(0.30)[0mp@FreeBSD.org,mpp302@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[95.91.244.55:received]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[0mp@FreeBSD.org,mpp302@gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; TO_DOM_EQ_FROM_DOM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.80)[-0.801]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; DMARC_NA(0.00)[FreeBSD.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_SPAM_SHORT(0.98)[0.981]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.41:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.41:from]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On 24/11/2021 16:28, Mateusz Piotrowski wrote: > The branch main has been updated by 0mp (doc, ports committer): > > URL: https://cgit.FreeBSD.org/src/commit/?id=169e06fa7852810f4ced2cce7a3c14ca9443bf39 > > commit 169e06fa7852810f4ced2cce7a3c14ca9443bf39 > Author: Mateusz Piotrowski <0mp@FreeBSD.org> > AuthorDate: 2021-11-23 10:26:47 +0000 > Commit: Mateusz Piotrowski <0mp@FreeBSD.org> > CommitDate: 2021-11-24 15:17:01 +0000 > > os-release: Quote variables as documented in the manual > > Variables must be quoted if they contain non-alphanumeric characters. > > Warner noted in the review that the lack of quoting causing problems > here is rather an edge case. I believe that it's worth adding the quotes > here anyway because this is what the specification says and there is no > good reason not to follow it. > > Reviewed by: imp > Approved by: imp (src) > MFC after: 7 days Differential revision: https://reviews.freebsd.org/D33092