Re: git: e528757ca6a9 - main - iicoc: add support for SiFive HiFive Unmatched
- In reply to: Jessica Clarke : "Re: git: e528757ca6a9 - main - iicoc: add support for SiFive HiFive Unmatched"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 02 Nov 2021 01:23:35 UTC
On 2021-11-01 20:55:42 (+0800), Jessica Clarke wrote: > On 1 Nov 2021, at 05:09, Philip Paeps <philip@FreeBSD.org> wrote: >> The branch main has been updated by philip: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=e528757ca6a9c03dca7e35b77411b311af166b7f >> >> commit e528757ca6a9c03dca7e35b77411b311af166b7f >> Author: Thomas Skibo <firstname.lastname@example.org> >> AuthorDate: 2021-11-01 04:23:22 +0000 >> Commit: Philip Paeps <philip@FreeBSD.org> >> CommitDate: 2021-11-01 04:26:49 +0000 >> >> iicoc: add support for SiFive HiFive Unmatched >> >> Reviewed by: jrtc27, philip >> MFC after: 3 days >> Differential Revision: https://reviews.freebsd.org/D32737 > > I didn’t approve the revision, I just left comments on the first > version. Oh! I'm sorry. I misread the Phabricator "accepted by riscv group" tick. I thought that was yours ... turns out it was mine. :-o > One of which still stands (not limiting the module to RISC-V). I agree it would make sense to build the module for all platforms. I'll make that happen. Sorry for jumping the gun. Philip -- Philip Paeps Senior Reality Engineer Alternative Enterprises