Re: git: e528757ca6a9 - main - iicoc: add support for SiFive HiFive Unmatched

From: Jessica Clarke <jrtc27_at_freebsd.org>
Date: Mon, 01 Nov 2021 12:55:42 UTC 
On 1 Nov 2021, at 05:09, Philip Paeps <philip@FreeBSD.org> wrote:
> 
> The branch main has been updated by philip:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=e528757ca6a9c03dca7e35b77411b311af166b7f
> 
> commit e528757ca6a9c03dca7e35b77411b311af166b7f
> Author:     Thomas Skibo <thomas-bsd@skibo.net>
> AuthorDate: 2021-11-01 04:23:22 +0000
> Commit:     Philip Paeps <philip@FreeBSD.org>
> CommitDate: 2021-11-01 04:26:49 +0000
> 
>    iicoc: add support for SiFive HiFive Unmatched
> 
>    Reviewed by:    jrtc27, philip
>    MFC after:      3 days
>    Differential Revision:  https://reviews.freebsd.org/D32737

I didn’t approve the revision, I just left comments on the first
version. One of which still stands (not limiting the module to RISC-V).

Jess

> ---
> sys/dev/iicbus/iicoc_fdt.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/sys/dev/iicbus/iicoc_fdt.c b/sys/dev/iicbus/iicoc_fdt.c
> index 699a1738f53b..052174a91134 100644
> --- a/sys/dev/iicbus/iicoc_fdt.c
> +++ b/sys/dev/iicbus/iicoc_fdt.c
> @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$");
> 
> static struct ofw_compat_data compat_data[] = {
> 	{ "opencores,i2c-ocores",	1 },
> +	{ "sifive,fu740-c000-i2c",	1 },
> +	{ "sifive,fu540-c000-i2c",	1 },
> +	{ "sifive,i2c0",		1 },
> 	{ NULL,				0 }
> };
>