git: 0aeee1f074a7 - stable/13 - pf: fix some cc --analyze warnings

The branch stable/13 has been updated by kp:

URL: https://cgit.FreeBSD.org/src/commit/?id=0aeee1f074a7a5e53d5a8f1c2eb61bd5285f4fae

commit 0aeee1f074a7a5e53d5a8f1c2eb61bd5285f4fae
Author:     Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2021-10-19 11:57:47 +0000
Commit:     Kristof Provost <kp@FreeBSD.org>
CommitDate: 2023-06-30 07:06:44 +0000

    pf: fix some cc --analyze warnings
    
    Reviewed by:    kp
    Sponsored by:   Rubicon Communications, LLC ("Netgate")
    
    (cherry picked from commit bcd4c17ccaacf995224882dc1d05e2a51867bdf2)
---
 sys/netpfil/pf/if_pfsync.c | 2 +-
 sys/netpfil/pf/pf_ioctl.c  | 2 +-
 sys/netpfil/pf/pf_norm.c   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c
index b05e1ae9550a..9cf1071b3248 100644
--- a/sys/netpfil/pf/if_pfsync.c
+++ b/sys/netpfil/pf/if_pfsync.c
@@ -2545,7 +2545,7 @@ VNET_SYSINIT(vnet_pfsync_init, SI_SUB_PROTO_FIREWALL, SI_ORDER_ANY,
 static void
 vnet_pfsync_uninit(const void *unused __unused)
 {
-	int ret;
+	int ret __diagused;
 
 	pfsync_pointers_uninit();
 
diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c
index 00021655605b..07463ecbbcf3 100644
--- a/sys/netpfil/pf/pf_ioctl.c
+++ b/sys/netpfil/pf/pf_ioctl.c
@@ -5639,7 +5639,7 @@ hook_pf(void)
 {
 	struct pfil_hook_args pha;
 	struct pfil_link_args pla;
-	int ret;
+	int ret __diagused;
 
 	if (V_pf_pfil_hooked)
 		return;
diff --git a/sys/netpfil/pf/pf_norm.c b/sys/netpfil/pf/pf_norm.c
index 56b30faf7e52..cac9c1fe391f 100644
--- a/sys/netpfil/pf/pf_norm.c
+++ b/sys/netpfil/pf/pf_norm.c
@@ -1002,7 +1002,7 @@ pf_refragment6(struct ifnet *ifp, struct mbuf **m0, struct m_tag *mtag)
 		DPFPRINTF(("refragment error %d\n", error));
 		action = PF_DROP;
 	}
-	for (t = m; m; m = t) {
+	for (; m; m = t) {
 		t = m->m_nextpkt;
 		m->m_nextpkt = NULL;
 		m->m_flags |= M_SKIP_FIREWALL;