From nobody Fri Jun 30 08:17:35 2023 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qsp8b6W1Jz4jsqB; Fri, 30 Jun 2023 08:17:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qsp8b5zgvz4Qsj; Fri, 30 Jun 2023 08:17:35 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688113055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a4NQapghSRIoM871m190P5HX0sC+7zdeS7FY63q6moM=; b=VlpOMY5YxxVhhDJEXrsQxTItfUIqdWDP0+BJs0v2XVefALUao6wcYMiWkeU/SQhLcnwZiV aTPvMZ1CkJ0qq5PBC5eLS8yeVKbyaLpQMtrLLi/3l6Hxv09KZssw6XqSXGgPAKEF5wWTG+ 8YJDmXOibWdfyd53SA6e3e+qCr8IZf/jObqoF/dYtYszzZVEjpReA/vnC8dt2TVzYT5OPX fl/sQdWdKCku2Bp/EuCoOU3hLLd22z/vxlGb0HDfeneP//Luuiq+Z8w1TUQBgTUlT1uwMs i5twoHbS9j6q6CJL0U5CvRz9qnEm74bsewhEuC2q9+13RNuNl9o4uS9BT9f5/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688113055; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a4NQapghSRIoM871m190P5HX0sC+7zdeS7FY63q6moM=; b=Gh79PVoW0dWU36/jRRfemAPNTdj7dvm0ZCa8DsThWAmh1IrSOm0Yn+JD4ZyPuLlcy+aymF I43VS9IzZabo2GAtJBX8tvDQCbLGCHFma0anbsaAOfZmSnbta+P+PNaRvskBiZqeH+LSxW wynCgiKI0tt5/laba1zoK2osVnoHZrCk9YqeI1BeG8aOc08YDF09WPrakKz0BNHCU8NSBT fls5dbH2iuCqggxO+w8v+ybTFTHdzmCfHtMPLWTU70T+8bVD0NitkKgzLD3UKaIMb2eoza s6tSonTtpK6A333IaqAor36/u9X0cbNrNpnc3o96eXL8Jq0WFG7TX80hw1h6WA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688113055; a=rsa-sha256; cv=none; b=XX/gn9lQm2r9GDlyrqbWDAj6ASHEC21xoJB6+wum5oSW+ikQNshTc+9fKj86RnuO2vitRn uVXtp6s6DeOqogGD20YUGIHgHxe90+mCHFJcMOwxNCVCkh7kpfcM8uJiTJLBYzEA1+ZMpJ 7Dq3UqdTvucVM2p9QNyFX8jWQyVcPtnt1q7O/Nsf0Rrnvw7UvYA7rFUBa4z8QWxD9WIrgw dM3J94SftL62fbrs0vSFPtm7UaKRuB5QobyuJo9vXBSu/8ki6JHOxsRjpMjKQPGk6W3Y4Y /zlXLBKIGUyb/U+KBWLBQ+6mXuaGHY1XIqTtLG4vQlVIdCHLiUZkIJG6RMgcJw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Qsp8b4wgNzrhD; Fri, 30 Jun 2023 08:17:35 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 35U8HZZS070233; Fri, 30 Jun 2023 08:17:35 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 35U8HZtX070232; Fri, 30 Jun 2023 08:17:35 GMT (envelope-from git) Date: Fri, 30 Jun 2023 08:17:35 GMT Message-Id: <202306300817.35U8HZtX070232@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kristof Provost Subject: git: 0aeee1f074a7 - stable/13 - pf: fix some cc --analyze warnings List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-branches@freebsd.org X-BeenThere: dev-commits-src-branches@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 0aeee1f074a7a5e53d5a8f1c2eb61bd5285f4fae Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=0aeee1f074a7a5e53d5a8f1c2eb61bd5285f4fae commit 0aeee1f074a7a5e53d5a8f1c2eb61bd5285f4fae Author: Mateusz Guzik AuthorDate: 2021-10-19 11:57:47 +0000 Commit: Kristof Provost CommitDate: 2023-06-30 07:06:44 +0000 pf: fix some cc --analyze warnings Reviewed by: kp Sponsored by: Rubicon Communications, LLC ("Netgate") (cherry picked from commit bcd4c17ccaacf995224882dc1d05e2a51867bdf2) --- sys/netpfil/pf/if_pfsync.c | 2 +- sys/netpfil/pf/pf_ioctl.c | 2 +- sys/netpfil/pf/pf_norm.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index b05e1ae9550a..9cf1071b3248 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -2545,7 +2545,7 @@ VNET_SYSINIT(vnet_pfsync_init, SI_SUB_PROTO_FIREWALL, SI_ORDER_ANY, static void vnet_pfsync_uninit(const void *unused __unused) { - int ret; + int ret __diagused; pfsync_pointers_uninit(); diff --git a/sys/netpfil/pf/pf_ioctl.c b/sys/netpfil/pf/pf_ioctl.c index 00021655605b..07463ecbbcf3 100644 --- a/sys/netpfil/pf/pf_ioctl.c +++ b/sys/netpfil/pf/pf_ioctl.c @@ -5639,7 +5639,7 @@ hook_pf(void) { struct pfil_hook_args pha; struct pfil_link_args pla; - int ret; + int ret __diagused; if (V_pf_pfil_hooked) return; diff --git a/sys/netpfil/pf/pf_norm.c b/sys/netpfil/pf/pf_norm.c index 56b30faf7e52..cac9c1fe391f 100644 --- a/sys/netpfil/pf/pf_norm.c +++ b/sys/netpfil/pf/pf_norm.c @@ -1002,7 +1002,7 @@ pf_refragment6(struct ifnet *ifp, struct mbuf **m0, struct m_tag *mtag) DPFPRINTF(("refragment error %d\n", error)); action = PF_DROP; } - for (t = m; m; m = t) { + for (; m; m = t) { t = m->m_nextpkt; m->m_nextpkt = NULL; m->m_flags |= M_SKIP_FIREWALL;