Re: git: 32137c41065c - main - sound: Retire the version constants
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 23 Sep 2026 19:19:16 UTC
On 9/22/26 14:54, Jason Harmening wrote: > Do you plan to also bump __FreeBSD_version__ for these changes? > This will break any out-of-tree sound driver that uses these macros, > particularly if you MFC it. > Such drivers will then need some way to determine whether to hardcode '1' > or use the previous macro/hardcode '5' to avoid a failed dependency check. > I still maintain such a thing, however few users there may be, and it seems > unsafe to assume there aren't others. > > This seems like a completely unnecessary change TBH. Can you use #ifdef to test if they are defined in an out-of-tree driver? In your case, perhaps as something like: #ifndef SOUND_MINVER #define SOUND_MINVER 1 #endif and similar for the other two macros. -- John Baldwin