From nobody Wed Sep 23 19:19:16 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hqmxC4QRXz6smYp; Wed, 23 Sep 2026 19:19:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [66.216.25.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4hqmxB4S1cz3NB5; Wed, 23 Sep 2026 19:19:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Authentication-Results: mx1.freebsd.org; dkim=none; spf=softfail (mx1.freebsd.org: 66.216.25.90 is neither permitted nor denied by domain of jhb@FreeBSD.org) smtp.mailfrom=jhb@FreeBSD.org; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=freebsd.org (policy=none) Received: by mail.baldwin.cx (Postfix) id BF36A1BDE4; Wed, 23 Sep 2026 15:19:17 -0400 (EDT) Message-ID: <2df20868-4983-4169-a94e-da6adf2fb3ea@FreeBSD.org> Date: Wed, 23 Sep 2026 15:19:16 -0400 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 32137c41065c - main - sound: Retire the version constants Content-Language: en-US To: Jason Harmening , Christos Margiolis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <6ab2bc22.412bd.10bb456f@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.4 (mail.baldwin.cx [0.0.0.0]); Wed, 23 Sep 2026 15:19:17 -0400 (EDT) X-Virus-Scanned: clamav-milter 1.5.2 at mail.baldwin.cx X-Virus-Status: Clean X-Spamd-Bar: / X-Spamd-Result: default: False [0.20 / 15.00]; ONCE_RECEIVED(0.20)[]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : No valid SPF, No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com,freebsd.org]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[jhb]; ASN(0.00)[asn:19151, ipnet:66.216.0.0/18, country:US]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; R_DKIM_NA(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; R_SPF_SOFTFAIL(0.00)[~all]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; TO_MATCH_ENVRCPT_SOME(0.00)[]; ALIAS_RESOLVED(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_FIVE(0.00)[5] X-Rspamd-Queue-Id: 4hqmxB4S1cz3NB5 On 9/22/26 14:54, Jason Harmening wrote: > Do you plan to also bump __FreeBSD_version__ for these changes? > This will break any out-of-tree sound driver that uses these macros, > particularly if you MFC it. > Such drivers will then need some way to determine whether to hardcode '1' > or use the previous macro/hardcode '5' to avoid a failed dependency check. > I still maintain such a thing, however few users there may be, and it seems > unsafe to assume there aren't others. > > This seems like a completely unnecessary change TBH. Can you use #ifdef to test if they are defined in an out-of-tree driver? In your case, perhaps as something like: #ifndef SOUND_MINVER #define SOUND_MINVER 1 #endif and similar for the other two macros. -- John Baldwin