git: 03b59d2e7df2 - main - sound: Do not set a recording source in mixer_uninit()
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 18 Sep 2026 18:18:43 UTC
The branch main has been updated by christos:
URL: https://cgit.FreeBSD.org/src/commit/?id=03b59d2e7df263ea5a8904e5593d14f6e3e0fbd8
commit 03b59d2e7df263ea5a8904e5593d14f6e3e0fbd8
Author: Christos Margiolis <christos@FreeBSD.org>
AuthorDate: 2026-09-18 18:16:40 +0000
Commit: Christos Margiolis <christos@FreeBSD.org>
CommitDate: 2026-09-18 18:16:40 +0000
sound: Do not set a recording source in mixer_uninit()
We currently set the recording source to SOUND_MIXER_MIC during mixer
deletion. Apart from the fact that this control might not be present on
all devices, it is unnecessary to do that, plus we already set all the
volumes to 0 in the mixer_set() call above.
Sponsored by: The FreeBSD Foundation
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D59076
---
sys/dev/sound/pcm/mixer.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sys/dev/sound/pcm/mixer.c b/sys/dev/sound/pcm/mixer.c
index bad464538609..c0d05b5d195d 100644
--- a/sys/dev/sound/pcm/mixer.c
+++ b/sys/dev/sound/pcm/mixer.c
@@ -629,8 +629,6 @@ mixer_uninit(device_t dev)
for (i = 0; i < SOUND_MIXER_NRDEVICES; i++)
mixer_set(m, i, 0, 0);
- mixer_setrecsrc(m, SOUND_MASK_MIC);
-
mtx_unlock(m->lock);
/* mixer uninit can sleep --hps */