From nobody Fri Sep 18 18:18:43 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hmgqR746lz6spNB for ; Fri, 18 Sep 2026 18:18:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR2" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hmgqR4YKSz4Nqp for ; Fri, 18 Sep 2026 18:18:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789755523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cP8l6nguevL/d7UXjTtoWNdC/qhaKX4jehGYK/eNftI=; b=PkFJx2szwvxTAuhr591jwTeAwDNly4XFfctYIiIF3E0wHWgwtB5iBgWYXkCeiJF0s0etUl 15jkCyTLDDmAo3g1x4Es85IKRCqXdiMyNu723NzZfqw3fNFDuQvUG/dwXCIOb/K9LaiSIy hu1PcpV2Ru/ySj+WmfOzjkDmIv224r9Mdndo4grXoqqosIK1DVa3C4e4hNe9f9rt/rjc6J 1ybdUMtsI8yrGbqDvbQVLaJNjoAhTctqAMDDNG6PvMxjwSXh6npuMx1wAcVmh8kDsiPqBQ demEh/Gb3JpM4In5ZnNyJEetjdj8LFGazYKU2uU/nXFOX9ugxuAk4zWY133i3A== ARC-Seal: i=1; a=rsa-sha256; d=freebsd.org; s=dkim; cv=none; t=1789755523; b=oPh89f+0e4Q8o4rIx9X2/wXalfJV6Fhyw+NJna1/VYO3UGcjgpPRuSZSzEvjShhfXiMv+O hmcIgEyQEKbY6aZz6PoQn9EJfURiOLOLvMoVCwittK8SA/25VkRve+EWSaEE+XVU+ekloA x8U6A/Iz40tLN4jbBLLUWm33UOGCHGFBshTBuSg6pLj1Hs+3rClfIFbmjT5hJyeZJDnNwD PHUL7IDvGE2B9caQeiKt74vmgBcpHWRlB+JhLyrVyr3jyckp3eJq90ocIUPMnadk7J71nV ntMiiRiPKeChoRSCvhl/9P2hP4aNw5AN49nKLoiUTym9gSX/beedQHxMUgHBHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1789755523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=cP8l6nguevL/d7UXjTtoWNdC/qhaKX4jehGYK/eNftI=; b=lIiTBIeGW7miDAbx9X/Qnw0UyBrYYKrfLPCjnHwdfUgwohCOFVbQcfIihwArSI+p697mSY 6hW3t30NRNipifP3wrMfzZzNeBGUniJok0QmwzujF9WEQIP4ZIrWBphCzYyQMvpiMvi7gP aM1un2Mr3pUp5fVghihPI+qxekAqwIkQv3HVqpaYxKW216r9PL+FiDt/gD6vTCDH/vboLH BmNcFa9pf4gnej/a3eip7QDOdeaTFNxQix8UBp9bMAqafiQkHl2ziNQ2/5s5JxZJbypP3N 4xND1yY15LcUwHNcaOnuPHM2JZKA4Dh2Hgix5ZhEtfaMqReFyTyRc5n2S/wvDQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4hmgqR20pfzV7G for ; Fri, 18 Sep 2026 18:18:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 37570 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 18 Sep 2026 18:18:43 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 03b59d2e7df2 - main - sound: Do not set a recording source in mixer_uninit() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 03b59d2e7df263ea5a8904e5593d14f6e3e0fbd8 Auto-Submitted: auto-generated Date: Fri, 18 Sep 2026 18:18:43 +0000 Message-Id: <6aad8083.37570.3bc9e7bf@gitrepo.freebsd.org> The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=03b59d2e7df263ea5a8904e5593d14f6e3e0fbd8 commit 03b59d2e7df263ea5a8904e5593d14f6e3e0fbd8 Author: Christos Margiolis AuthorDate: 2026-09-18 18:16:40 +0000 Commit: Christos Margiolis CommitDate: 2026-09-18 18:16:40 +0000 sound: Do not set a recording source in mixer_uninit() We currently set the recording source to SOUND_MIXER_MIC during mixer deletion. Apart from the fact that this control might not be present on all devices, it is unnecessary to do that, plus we already set all the volumes to 0 in the mixer_set() call above. Sponsored by: The FreeBSD Foundation MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D59076 --- sys/dev/sound/pcm/mixer.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/dev/sound/pcm/mixer.c b/sys/dev/sound/pcm/mixer.c index bad464538609..c0d05b5d195d 100644 --- a/sys/dev/sound/pcm/mixer.c +++ b/sys/dev/sound/pcm/mixer.c @@ -629,8 +629,6 @@ mixer_uninit(device_t dev) for (i = 0; i < SOUND_MIXER_NRDEVICES; i++) mixer_set(m, i, 0, 0); - mixer_setrecsrc(m, SOUND_MASK_MIC); - mtx_unlock(m->lock); /* mixer uninit can sleep --hps */