Re: git: e32b082ba28b - main - clk: rockchip: Add the MMC phase clock
Date: Sat, 31 Oct 2026 22:32:52 UTC
> On Oct 31, 2026, at 3:29 PM, Mark Millard <marklmi@yahoo.com> wrote: > > On 10/31/26 14:12, Enji Cooper (yaneurabeya) wrote: >> >>> On Oct 30, 2026, at 12:36 AM, Emmanuel Vadot <manu@FreeBSD.org> wrote: >>> >>> The branch main has been updated by manu: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=e32b082ba28bd3d0e026782eeb93f124ced7508f >>> >>> commit e32b082ba28bd3d0e026782eeb93f124ced7508f >>> Author: Emmanuel Vadot <manu@FreeBSD.org> >>> AuthorDate: 2026-10-20 08:09:18 +0000 >>> Commit: Emmanuel Vadot <manu@FreeBSD.org> >>> CommitDate: 2026-10-30 07:36:46 +0000 >>> >>> clk: rockchip: Add the MMC phase clock >>> >>> Add a clock node type for the Rockchip MMC sample and drive clocks. These >>> clocks have a phase in degrees controlled by a delay line and a fine-grained >>> phase selector, and implement the new clknode phase methods. >>> >>> Reviewed by: mmel >>> Differential Revision: https://reviews.freebsd.org/D60886 >> >> Hi manu, >> >> This change broke armv7: https://ci.freebsd.org/job/FreeBSD-main-armv7-build/29954/ . >> >> I’m testing this fix: >> >> universe16a% git diff >> diff --git a/sys/arm/rockchip/files.rk32xx b/sys/arm/rockchip/files.rk32xx >> index 2faee11b0b6a..5595f37e9a5a 100644 >> --- a/sys/arm/rockchip/files.rk32xx >> +++ b/sys/arm/rockchip/files.rk32xx >> @@ -17,6 +17,7 @@ dev/clk/rockchip/rk_clk_armclk.c standard >> dev/clk//rockchip/rk_clk_composite.c standard >> dev/clk//rockchip/rk_clk_fract.c standard >> dev/clk//rockchip/rk_clk_gate.c standard >> +dev/clk//rockchip/rk_clk_mmc.c standard >> dev/clk//rockchip/rk_clk_mux.c standard >> dev/clk//rockchip/rk_clk_pll.c standard >> dev/clk//rockchip/rk_cru.c standard >> >> Thanks, >> -Enji > > I see distinct blocks with 2 district type of error messages: > > 1st: > > 19:38:06 error: unable to normalize alternate object path: > /home/git/src.git/objects > 19:38:06 --- modules-all --- > 19:38:06 awk -f /usr/src/sys/tools/makeobjops.awk > /usr/src/sys/dev/ofw/ofw_bus_if.m -h > 19:38:06 --- all_subdir_ath_hal_ar5210 --- > 19:38:06 ctfconvert -L VERSION -g ar5210_attach.o > 19:38:06 --- vers.c --- > 19:38:06 error: unable to normalize alternate object path: > /home/git/src.git/objects > 19:38:06 error: unable to normalize alternate object path: > /home/git/src.git/objects > 19:38:06 fatal: bad object HEAD > 19:38:06 --- vers.o --- > > 2nd: > > 19:38:06 --- kernel.full --- > 19:38:06 ld: error: undefined symbol: rk_clk_mmc_register > 19:38:06 >>> referenced by rk_cru.c:267 > (/usr/src/sys/dev/clk/rockchip/rk_cru.c:267) > 19:38:06 >>> rk_cru.o:(rk_cru_attach) > 19:38:06 --- modules-all --- > . . . > 19:38:11 --- kernel.full --- > 19:38:11 ld: error: undefined symbol: rk_clk_mmc_register > 19:38:11 >>> referenced by rk_cru.c:267 > (/usr/src/sys/dev/clk/rockchip/rk_cru.c:267) > 19:38:11 >>> rk_cru.o:(rk_cru_attach) > 19:38:11 --- modules-all --- > 19:38:11 --- all_subdir_ath_hal_ar5210 — Good eye: something under sys/modules will need updating too. -Enji