From nobody Sat Oct 31 22:32:52 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jHCRB1gJ9z6xS0t for ; Sat, 31 Oct 2026 22:33:10 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jHCR92SCDz3CdD for ; Sat, 31 Oct 2026 22:33:09 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20260707 header.b=P4wJZvK5; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::102c as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-x102c.google.com with SMTP id 98e67ed59e1d1-3ac77270fbfso886200a91.2 for ; Sat, 31 Oct 2026 15:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793485987; x=1794090787; darn=freebsd.org; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:from:to:cc:subject:date:message-id :reply-to:content-type; bh=LP8gxRBDjdxiuYk1HV589lS+refnZFBtRcikhnUxFU4=; b=P4wJZvK5vCN06Qm2ElPgXcHAKhWSPomO+ifj1OtANFw7uII8OPn8wHPnA2dx1kzQxY 6fPGG29VDKcj7r0fZGzqOH1LUmNyj/dzlo+XrUpPeET7Tqdbm0mxI4pTsTB3fXCTxXJI buysb29nCKb8cAUQHPzVSZpFGGbpZG2/ZVrrcDYXEwVlG1GaBVBG/28Oy7H1QsWXRWOg jMclDhak1m/Ch2vGz29envqYdphJ12wrtFBjV0jR1Vg/Ib71ouXF9os920R1iCB/JwFT STC7CwtUkgv0afXZ9q37QNdOFserhNn+r5k1bzeKxGTzAsvlmxcriaTZmgGoueJZf9o+ v+sA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793485987; x=1794090787; h=to:references:message-id:cc:date:in-reply-to:from:subject :mime-version:content-type:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=LP8gxRBDjdxiuYk1HV589lS+refnZFBtRcikhnUxFU4=; b=SFWdju2peyV1JODhsaSzqHfanRKz8gI+1tefLmC0AGlLaJQ7LhwZvkPntDtsrjkMYu NUsRB0QqTgKLRCz3yp3XMmxH0u4Us/jtQ/q8yjDKxuvYATHVk8Wsc/3/uocHCBvCAC2k rCe6AAOPetAJK80Ff7mrqSjP+7tmGpT/NCe7ff4AaVdSJjKjfBg46DavWnhT5rvKhbqv 7XFE0LuHXvDa8G9HsdsUCo+gxL0F2NZP16gfIcK9Emcp10kYXqKm5GYYKuI/IZVH3I24 OtAXBRsjSUeFiZErV2a/gP0LHu7bS56IMB3IYXE+EUNGeU+SqhFL9+/UCl9IoGwTTLHa oqUg== X-Forwarded-Encrypted: i=1; AKwUvByTQeMxcFRqoKVIn3m8QGhtb9RTrlVaol/9E4MNiHqEFCAzJ7yDBjgrW3QECt3PP0PF92vDTxR04BNvVqAHl5ijysSh@freebsd.org X-Gm-Message-State: AFq9FYIdHvPlCByxdXlyi8GkadFViNiD7SFya6OXgQ/aBjoKgOqWpLqw JUS8lVCm7G/AHaW8eYGbZg+p80wY33UNyBPxvaESdngnJyFAQV67cJJjn81pfw== X-Gm-Gg: AYBFou1BiYXwVmOin3jXjYDFTcKSXp/yoYDJaW4ywzfVj7YQshbmklofR/c3aOrjXWt +XnAas0vhhE0t1i0Uo9L5t4Ds22NFQLr2TyOctiTTauSlR+cG0zjypcTGm4w01G/ttKKdh7fIU/ dgr0rMJ3Ex0Z0IzAUCfbBD2FJgkcJv/it5rHkQ1yfu++OyM0VzzzTR9cAdvWBDFupE8/nQYHtTi zd74+4vrNVsZAkfhjSAys6ZJnXQORNtHxksisjFRXWUpS/wqjhH5uv5qYtLeqTfelOkNIAqtNCh kceUkEcB6XP0lYGvQzAVeOja0A1kPW2kB31VhTqQV44sUKx5JPaTstSrQfap7Yj+1UeELDHRFFX 8nwuj7wLfKoMfa7PizQzM8Kxpi3rf2V1yZF6SCKe8FR4zPEFZkfml+2gKKwmH6ehH+5hPX6gTzE 7vaj55kuQ/hHNyl+BHyfYX7gkc2m2VAhBNYZ9AgvChpOkMnIG7rrTjcbpmwGl+d9GHJJDsaIZ+7 /+gtMrHz2Klc1nt+3MaPSIpfUG5cadsBGqsGY2P68qvsHwWPldc+HoE1tHyOpAD3qa7TJultD5z BY7cIqbj7tpIPcVaboRRAZr/Ye3qYqEN3mpf8ZXWSGHWp+b1yO4Y876pLVtylJwYNIFVpUu3 X-Received: by 2002:a17:90b:2745:b0:3a4:b0a1:c7ed with SMTP id 98e67ed59e1d1-3ae89776d99mr5152010a91.13.1793485986794; Sat, 31 Oct 2026 15:33:06 -0700 (PDT) Received: from smtpclient.apple ([187.15.154.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae6e7d429fsm12988629a91.2.2026.10.31.15.33.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Oct 2026 15:33:05 -0700 (PDT) Content-Type: multipart/signed; boundary="Apple-Mail=_A5020FC1-A56D-4005-A6A6-5B4F20E6057B"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.3\)) Subject: Re: git: e32b082ba28b - main - clk: rockchip: Add the MMC phase clock From: "Enji Cooper (yaneurabeya)" In-Reply-To: Date: Sat, 31 Oct 2026 15:32:52 -0700 Cc: Emmanuel Vadot , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Message-Id: References: <6ae4491b.20677.5ae1a95b@gitrepo.freebsd.org> <9D8083B9-5DE3-4D05-98B0-6AAF4754FCE7@gmail.com> To: Mark Millard X-Mailer: Apple Mail (2.3864.700.51.1.3) X-Rspamd-Queue-Id: 4jHCR92SCDz3CdD X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; SIGNED_PGP(-2.00)[]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20260707]; FREEMAIL_TO(0.00)[yahoo.com]; RCVD_TLS_LAST(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_THREE(0.00)[4]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::102c:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; HAS_ATTACHMENT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] --Apple-Mail=_A5020FC1-A56D-4005-A6A6-5B4F20E6057B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 31, 2026, at 3:29=E2=80=AFPM, Mark Millard = wrote: >=20 > On 10/31/26 14:12, Enji Cooper (yaneurabeya) wrote: >>=20 >>> On Oct 30, 2026, at 12:36=E2=80=AFAM, Emmanuel Vadot = wrote: >>>=20 >>> The branch main has been updated by manu: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3De32b082ba28bd3d0e026782eeb93f124= ced7508f >>>=20 >>> commit e32b082ba28bd3d0e026782eeb93f124ced7508f >>> Author: Emmanuel Vadot >>> AuthorDate: 2026-10-20 08:09:18 +0000 >>> Commit: Emmanuel Vadot >>> CommitDate: 2026-10-30 07:36:46 +0000 >>>=20 >>> clk: rockchip: Add the MMC phase clock >>>=20 >>> Add a clock node type for the Rockchip MMC sample and drive = clocks. These >>> clocks have a phase in degrees controlled by a delay line and a = fine-grained >>> phase selector, and implement the new clknode phase methods. >>>=20 >>> Reviewed by: mmel >>> Differential Revision: https://reviews.freebsd.org/D60886 >>=20 >> Hi manu, >>=20 >> This change broke armv7: = https://ci.freebsd.org/job/FreeBSD-main-armv7-build/29954/ . >>=20 >> I=E2=80=99m testing this fix: >>=20 >> universe16a% git diff >> diff --git a/sys/arm/rockchip/files.rk32xx = b/sys/arm/rockchip/files.rk32xx >> index 2faee11b0b6a..5595f37e9a5a 100644 >> --- a/sys/arm/rockchip/files.rk32xx >> +++ b/sys/arm/rockchip/files.rk32xx >> @@ -17,6 +17,7 @@ dev/clk/rockchip/rk_clk_armclk.c standard >> dev/clk//rockchip/rk_clk_composite.c standard >> dev/clk//rockchip/rk_clk_fract.c standard >> dev/clk//rockchip/rk_clk_gate.c standard >> +dev/clk//rockchip/rk_clk_mmc.c standard >> dev/clk//rockchip/rk_clk_mux.c standard >> dev/clk//rockchip/rk_clk_pll.c standard >> dev/clk//rockchip/rk_cru.c standard >>=20 >> Thanks, >> -Enji >=20 > I see distinct blocks with 2 district type of error messages: >=20 > 1st: >=20 > 19:38:06 error: unable to normalize alternate object path: > /home/git/src.git/objects > 19:38:06 --- modules-all --- > 19:38:06 awk -f /usr/src/sys/tools/makeobjops.awk > /usr/src/sys/dev/ofw/ofw_bus_if.m -h > 19:38:06 --- all_subdir_ath_hal_ar5210 --- > 19:38:06 ctfconvert -L VERSION -g ar5210_attach.o > 19:38:06 --- vers.c --- > 19:38:06 error: unable to normalize alternate object path: > /home/git/src.git/objects > 19:38:06 error: unable to normalize alternate object path: > /home/git/src.git/objects > 19:38:06 fatal: bad object HEAD > 19:38:06 --- vers.o --- >=20 > 2nd: >=20 > 19:38:06 --- kernel.full --- > 19:38:06 ld: error: undefined symbol: rk_clk_mmc_register > 19:38:06 >>> referenced by rk_cru.c:267 > (/usr/src/sys/dev/clk/rockchip/rk_cru.c:267) > 19:38:06 >>> rk_cru.o:(rk_cru_attach) > 19:38:06 --- modules-all --- > . . . > 19:38:11 --- kernel.full --- > 19:38:11 ld: error: undefined symbol: rk_clk_mmc_register > 19:38:11 >>> referenced by rk_cru.c:267 > (/usr/src/sys/dev/clk/rockchip/rk_cru.c:267) > 19:38:11 >>> rk_cru.o:(rk_cru_attach) > 19:38:11 --- modules-all --- > 19:38:11 --- all_subdir_ath_hal_ar5210 =E2=80=94 Good eye: something under sys/modules will need updating too. -Enji --Apple-Mail=_A5020FC1-A56D-4005-A6A6-5B4F20E6057B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmrmbJQACgkQGpE5DjPs NJh/Kw/+LlhbKtv+L4EM2KKfGf7IWhEqhfTqmqW7IAXwHEWS/tiy9zhG1hzg2V/X iWaO3w4RS/fQ4wcH0A5mUiD/4+A25aWw9on6p5Rcmgq8oGCQwL11dKczIRd4Ll/R W3jA8Qz7r4cnDUV1Fs68Ccy8lHXvDeu7EFXjcx3bSagciZYCBKSisi5OcNKGHA6C bD8+ZssRe9Yx3uBfXP+JclK7G4mgc+zbZMeJ4tKO9mH02ImvKjbu+mnxLKDddMEj ntJ8GBJO3GGGUJZY2jqCdu91iKeWJbSpxCcj2lF0hDgqkf1xTMv6ezK8Q0QVxPDA woRDU/6+IuDcQfBpbxSA0+cbDHGIqRX+XTzzitcwoyx0WSYSUfFEKlvjt6LALCse a3VmTaCWVF8wA0RgyrdwCJpYu9zQCSsIaR5JU18Cz4ZRaGIGUBPSkMlVOpWB0RXf A9Oy7wm0F5IGSSKPxP8E38XtiMcYnENEICXjPxKevK2dIaE+Krz+eVQ8Uu+7S2iv 4GREznJzg+ObJoM+Hgsor8a3vGFBE9c08B7sFOohpNKf8fwTJ3voYNTLJpeN3N4Z 5X2apz7AjwxVO+UKziR1hh8gCnhmC9EkXxVM6bFOefeOp73SaDo41je5HIkY3J7c bqFl83nfF0mgHOJiFC822+ZqDwwj/rFfTEymkRp2PhbeYH97X0U= =alFK -----END PGP SIGNATURE----- --Apple-Mail=_A5020FC1-A56D-4005-A6A6-5B4F20E6057B--