Re: git: 68aebfa28a17 - main - style.Makefile(5): update recommendations

From: Enji Cooper (yaneurabeya) <yaneurabeya_at_gmail.com>
Date: Sat, 31 Oct 2026 20:48:17 UTC 
> On Oct 30, 2026, at 4:11 AM, Brooks Davis <brooks@FreeBSD.org> wrote:
> 
> On Thu, Oct 29, 2026 at 11:32:50PM +0000, Enji Cooper wrote:
>> The branch main has been updated by ngie:
>> 
>> URL: https://cgit.FreeBSD.org/src/commit/?id=68aebfa28a17189e1e697e612c0a1a2220b9fa2b
>> 
>> commit 68aebfa28a17189e1e697e612c0a1a2220b9fa2b
>> Author:     Enji Cooper <ngie@FreeBSD.org>
>> AuthorDate: 2026-10-29 20:47:36 +0000
>> Commit:     Enji Cooper <ngie@FreeBSD.org>
>> CommitDate: 2026-10-29 23:31:58 +0000
>> 
>>    style.Makefile(5): update recommendations
>> 
>>    - Mention `CXXFLAGS` and `CXXSTD`, in addition to `CFLAGS` and `CSTD`.
>>    - Mention `LIBADD`, in addition to the legacy (in-tree) variables,
>>      `DPADD` and `LDADD`.
>>    - Mention the other option types, e.g., `MK_FOO`, `WITHOUT_FOO`, etc,
>>      added as part of `src.opts.mk` in the past couple releases.
> 
> I don't think MK_FOO should be mentioned without a careful explination
> of the very narrow set of cases it should be set directly (basically
> bootstrapping and compat code).

I opened up a revision for an initial “crack” at some of the changes originally posted (by accident) with this change: https://reviews.freebsd.org/D61083 . I didn’t bother addressing `MK_FOO` in that differential because doing that requires a bit more care and nuance (as you pointed out).
Cheers,
-Enji