From nobody Sat Oct 31 20:48:17 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jH96W3kbZz6xHj0 for ; Sat, 31 Oct 2026 20:48:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jH96V5wknz4ZkL for ; Sat, 31 Oct 2026 20:48:34 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20260707 header.b=L9C3g09S; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::1030 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-3ae1b34e0d2so1538648a91.1 for ; Sat, 31 Oct 2026 13:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793479712; x=1794084512; darn=freebsd.org; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mwY3lLC79gg5SHGoDN12N928nyuEkfmobAknBFjwjYQ=; b=L9C3g09SLBAPcXrSE/ZI2hYgDQlh6ZmWKiCmG7hZI8UhkznicygcL2wSjamTsnNB79 RXwWgpWs6tSfgGDICqDrUdSjHxIyvOAy9muna/SZAiB/ZhbiduWRaYPM2ZJbpBDv5PNl qYqvIe7RXuFe+ucSjiDekS+Y8CiunB+/enG83O5grl+2aX4NoXYoTbzeKcW9BGvFQltz A+IXgwNCiiNfZ7ioAKURPq1YclNTecBalZ+wQ+QA0I4eGD9a+wr093gLzeqVXAP1HC22 Eay37rK/9Lz8/I9tTTgohvu/mb6JZOdpcx4g5EiDJoFzRzr507aS3wicGWxWcoqahT2Y pfUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793479712; x=1794084512; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mwY3lLC79gg5SHGoDN12N928nyuEkfmobAknBFjwjYQ=; b=PboVyZ8Ulolq8NvdI4SnA5mcN8QCwsBg105eTXwcWzZwPnDlac+WClnn91qncGvHax ehBbxvpMlGHSnGYcSpePotIfBgrFi6BLEIrmQlzV/NPRy5spb8wYaHqwAgmhl/dSw8jf hBCExsRgBbobW6yiS1pUgb1ank4Xr3Kq7niGLbboQ1VybUEyCTkBsKr7hK+W3P0HDK70 c/AwGcj1MEdyu/XNCxs3Hujj7D7u0DgwkbeBi8GWN9U4Av4MudlFWd8Q6q8CYdX8lI6H yVsS9VvpG2CxmHWp41U7V+T+YPmB9rLXb+aMczaqmTz1vdmHF5+l/WRh0aaLx6GyglLH irrA== X-Forwarded-Encrypted: i=1; AKwUvByx0uGZ7e4oBEGN6Y5hVqb30fNjBL9W/v/tG8+9xCiOxLMPFdofvG3ZiK/pntUr6M9/uTqv5izIKK3vJV5P/ufNazAt@freebsd.org X-Gm-Message-State: AFq9FYKDBQN7CcZB5uhdd1XJPblmj2LvbTjfFbUQ2yF0P9cENtk2evUw mEHYKF1daSzikOk5LoFXYqJlWSd/SUuI0PxdY6VJJXv9NDGs4uxudshH X-Gm-Gg: AYBFou2v2i7WNwZyQTcYOtUaebQJ409Z26VUPiAIlpJbzYPRhftSHOBey+QXQCk4Txu omEYmIhb4obGvHlWwCDAJvORc0SvOpsuoTadkqQIIiFiUZ8EeQHucV4t3UCmFgcpQlbL4zCg9Rk I0Zc5QglAO7kEXV5eHE25EoCFpqhxrngtO5N+laodEgFgHlMI+i0YCpFFXcD2eCh1UOwdy6AWlq ibY6iKn123Mnnx5QtwNSGUugUA0dlu33SdvIr92ih2cJOlEGz+jlOOyLNWDF+MmYRODWtpnCcpk jwz9QCQnO2UL861ebJyMM4Z1xCvUXMrpvAYi98B4hL8ilSdehnT6y87aKAnTsYb3H/k1T59e6Um o7AI74s/TMbtrd4DgPaZLSvqPPmE2fXgZJcGNmfkOSJ8M059rkuSN8wPVMIPJX9z73sWFSQEGQx +CKvha2KtSjmCkdej4D0htknyOR+jAyEekrQXhedER8go4VK+nZ7qCt+I89RsY54ZXM+Knwqnds jGUyrYeByvM1J9wSuBqYHDdODKYMIZBvUccWoUOOYclCKW0eA0SU2h7EEn80LsCj+bc/Zb9Lc6W lpOYsLlcK7MXm+BNPkSn2whM+By5DOrw1Qlu6Yo3d6lEMnQ/WIb3Bt7vAuXR3C+ZA1oGvvs2 X-Received: by 2002:a17:90b:4a4d:b0:3a0:d7f2:5a58 with SMTP id 98e67ed59e1d1-3ae89542f3dmr3400499a91.3.1793479712223; Sat, 31 Oct 2026 13:48:32 -0700 (PDT) Received: from smtpclient.apple ([187.15.154.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae85cb1bfdsm4948091a91.0.2026.10.31.13.48.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 Oct 2026 13:48:30 -0700 (PDT) From: "Enji Cooper (yaneurabeya)" Message-Id: <48AD4A94-718B-4EE0-A330-DCC3D45F77D2@gmail.com> Content-Type: multipart/signed; boundary="Apple-Mail=_96B7BCF0-EF7F-4FCA-8640-D52C462CCA20"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.3\)) Subject: Re: git: 68aebfa28a17 - main - style.Makefile(5): update recommendations Date: Sat, 31 Oct 2026 13:48:17 -0700 In-Reply-To: Cc: Enji Cooper , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org To: Brooks Davis References: <6ae3d7a2.3ab4d.29b4cc98@gitrepo.freebsd.org> X-Mailer: Apple Mail (2.3864.700.51.1.3) X-Rspamd-Queue-Id: 4jH96V5wknz4ZkL X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; SIGNED_PGP(-2.00)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; MIME_GOOD(-0.20)[multipart/signed,multipart/alternative,text/plain]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20260707]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~,4:~]; FROM_HAS_DN(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::1030:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; HAS_ATTACHMENT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] --Apple-Mail=_96B7BCF0-EF7F-4FCA-8640-D52C462CCA20 Content-Type: multipart/alternative; boundary="Apple-Mail=_0481C387-D717-47DE-AEBD-380C6FE7955B" --Apple-Mail=_0481C387-D717-47DE-AEBD-380C6FE7955B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 30, 2026, at 4:11=E2=80=AFAM, Brooks Davis = wrote: >=20 > On Thu, Oct 29, 2026 at 11:32:50PM +0000, Enji Cooper wrote: >> The branch main has been updated by ngie: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D68aebfa28a17189e1e697e612c0a1a22= 20b9fa2b >>=20 >> commit 68aebfa28a17189e1e697e612c0a1a2220b9fa2b >> Author: Enji Cooper >> AuthorDate: 2026-10-29 20:47:36 +0000 >> Commit: Enji Cooper >> CommitDate: 2026-10-29 23:31:58 +0000 >>=20 >> style.Makefile(5): update recommendations >>=20 >> - Mention `CXXFLAGS` and `CXXSTD`, in addition to `CFLAGS` and = `CSTD`. >> - Mention `LIBADD`, in addition to the legacy (in-tree) variables, >> `DPADD` and `LDADD`. >> - Mention the other option types, e.g., `MK_FOO`, `WITHOUT_FOO`, = etc, >> added as part of `src.opts.mk` in the past couple releases. >=20 > I don't think MK_FOO should be mentioned without a careful explination > of the very narrow set of cases it should be set directly (basically > bootstrapping and compat code). I opened up a revision for an initial =E2=80=9Ccrack=E2=80=9D at some of = the changes originally posted (by accident) with this change: = https://reviews.freebsd.org/D61083 . I didn=E2=80=99t bother addressing = `MK_FOO` in that differential because doing that requires a bit more = care and nuance (as you pointed out). Cheers, -Enji= --Apple-Mail=_0481C387-D717-47DE-AEBD-380C6FE7955B Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On= Oct 30, 2026, at 4:11=E2=80=AFAM, Brooks Davis = <brooks@FreeBSD.org> wrote:

On Thu, Oct 29, 2026 at 11:32:50PM +0000, = Enji Cooper wrote:
The branch main has been updated by ngie:

URL: = https://cgit.FreeBSD.org/src/commit/?id=3D68aebfa28a17189e1e697e612c0a1a22= 20b9fa2b

commit = 68aebfa28a17189e1e697e612c0a1a2220b9fa2b
Author: =     Enji Cooper = <ngie@FreeBSD.org>
AuthorDate: 2026-10-29 20:47:36 = +0000
Commit:     Enji Cooper = <ngie@FreeBSD.org>
CommitDate: 2026-10-29 23:31:58 = +0000

   style.Makefile(5): update = recommendations

   - Mention `CXXFLAGS` and = `CXXSTD`, in addition to `CFLAGS` and `CSTD`.
   - = Mention `LIBADD`, in addition to the legacy (in-tree) = variables,
     `DPADD` and = `LDADD`.
   - Mention the other option types, e.g., = `MK_FOO`, `WITHOUT_FOO`, etc,
     added as = part of `src.opts.mk` in the past couple releases.

I don't think MK_FOO should be mentioned = without a careful explination
of the very narrow set of cases it should = be set directly (basically
bootstrapping and compat code).

I opened up a revision for an = initial =E2=80=9Ccrack=E2=80=9D at some of the changes originally posted = (by accident) with this change: https://reviews.freebsd.org/D61083 = . I didn=E2=80=99t bother addressing `MK_FOO` in that differential = because doing that requires a bit more care and nuance (as you pointed = out).
Cheers,
-Enji
= --Apple-Mail=_0481C387-D717-47DE-AEBD-380C6FE7955B-- --Apple-Mail=_96B7BCF0-EF7F-4FCA-8640-D52C462CCA20 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmrmVBEACgkQGpE5DjPs NJghThAAn9bu0oG8h+2GVY2hq79qyO0Rk48IqRDQmPe6birZeJUeWYc05niU+es4 HB8MSKZEIOI9dS/ceLi6yFtlevHn59vnSAZ4m4GOeMvcj3woyMWIq5mZ+UjpgmjO lbnQAFdqGH6gZh1mi0aDeCP2j9QZsW4tw59iwejOZtRgmgnfpWo4+Brxm/9lry3v wxuf0FfRKLvo9kPN3UjyblffzftWHKkmHmx4f7rnLORzfJmJdr+aWnA+rF10fKIs 6FnjT+tnEkEYnsnw6pmBfehg28YDOMuxnsvCFxtKSuKFUcOtWbWXLyhPClkfQFND DFZNa0VSxoZljgAyeXWBMaBV2Di2WMP8V9jkBFCj8jZ3kiPw2dZEPlspSrtMu2h5 4iKnNQSZ40Gn2Jb2dCGwETb6bmJ9Ix35qbbMSABmKzG4paSR6ZykYH1YwGfrdxoZ RDsq68ZrvnhXYaJJ7pFEij6NoxTB8q5XRS1+bBB4gaJtNPyEOR4kGAx9XQUPA7+z n8uOr5X2LdxGHm8U/lclX3fLfU0cUIZyPVKAHKHXrxFmwN/pisiznmfwvH21IYBc xUYTtAbyE5y28QpvQ5jCUbmI9LBzZMrLnA4uAThD75CHk7/A2/YzVxqgCrE4le5N DoFdM8WaKSSZS5SkIFw1O8t7UVHWyRJ4qoTKanA5iPc9aKwaRK0= =dOY4 -----END PGP SIGNATURE----- --Apple-Mail=_96B7BCF0-EF7F-4FCA-8640-D52C462CCA20--