Re: git: 3fb03fb35b20 - main - [tests] switch GoogleTest tests to `googletest` interface
Date: Fri, 30 Oct 2026 23:11:19 UTC
> On Oct 30, 2026, at 2:59 PM, Enji Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: … > Well, some good news and bad news on this front. Good news: the tests will be run as root again as well as unprivileged users (diff pending), restoring test coverage. Bad news is that there will be “test result bloat”: there’s no way to really get around the fact that a ton of tests when run as an unprivileged user will be skipped with the same message (“requires root”). This can be fixed with some light refactoring, but it’s not a simple Makefile change like the (soon-to-be) proposed change will be. > > Some of the other permutations previously allowed with capsicum-test available in the larger test suite might need to be added (there are additional arguments which support different behavior in `capsicum-test-main.cc`), but this isn’t a regression since this was the way things were prior to 3fb03fb35b20d259e0a3a07fc48f2ecc3c5da6e8 . The only real net-change in behavior in the tests is that functional.sh explicitly tested root and non-root users and functional.sh ran the entire test suite, unlike kyua does with googletest now (kyua runs each testcase in isolation, process-wise). Review posted: https://reviews.freebsd.org/D61066 . -Enji