From nobody Fri Oct 30 23:11:19 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4jGcL02JlKz6xVK6 for ; Fri, 30 Oct 2026 23:11:36 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 4jGcKz25d8z4l2y for ; Fri, 30 Oct 2026 23:11:35 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20260707 header.b=X2tWB8Z9; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::52e as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-cc52c1b8286so716605a12.1 for ; Fri, 30 Oct 2026 16:11:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793401892; x=1794006692; darn=freebsd.org; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B8JFFfyUrM6KFXBIcTNkpNOARx/ULDQbcEwsPs4Jx3E=; b=X2tWB8Z9L33nKMEfTt8SMP3N3xI9ciTpmhaNvQ2Jv5/7tOhBL00BvDJ4YzkUC20hXD OcWIrmTfqsRa6vLOew0XnEwBcduz1yAWWfX2EJO61PAPUIRA538lgyOHA86GEC5g5g4L 00ZtxgxzywArZjtp9lqw00dIJYISu8dvCbzNaMsea1GIOc6TFqYD3LXvmXVZCI0u5u/v H5duXRC5DlXrJAajzVzV4bATCzRMqplFTJORWJ5j57E/XRr5RtZvPWDX+IDAmtWRq3pD 2AFYjcGNaT0c2PRdS4wRt9m+S8Kye71l7KWlPzxCM9x3W1eOxPyO6OdOr3DLjSgi/1yn 9qVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793401892; x=1794006692; h=references:to:cc:in-reply-to:date:subject:mime-version:content-type :message-id:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B8JFFfyUrM6KFXBIcTNkpNOARx/ULDQbcEwsPs4Jx3E=; b=Got6c0hwabYp0gccSgE0q+wrZCf3sWJQVhgJCxkkcg+hQZ/L5wwiX2qlpJejV1Ss2r J0d19ToTHjkjh2PX4Gcw4kKFlnyz/vBnCAL6jn/HjiyhXO3/yL4Ocp6DitMPnTx9BZaZ a+0xSFcPDddZr5SH8P2cbEUg3Fz+ti5CkWCZ73w4EnTnAcvzyOZCq7Dy14v4T+KRK5GP GoD4/joON3WHZJSkoDZYvQmHn5jTZmmjpBjLl86F4ScLn5BFXYg3NaoXar4hpBRglpvZ tGJ2UXjb+wqN9P+HUxUVcpoU2vSm3DLBRyV59KCeaJ1sl0qE+yZMe717Raz/z94d7aZv xRTw== X-Forwarded-Encrypted: i=1; AKwUvBy8+AQky/ImbK+IfidaNslHY4Wk2HR+tU9aJ4ljJ2zauYZHLevApXVWHpR0IuzzK8l/bTd2x+QsfRNL0BjJoLZqLX7j@freebsd.org X-Gm-Message-State: AFq9FYKODKS5hMY4hdKavyIzF9dWictGSOAOWM1ueXjx+7I6SvnCqtcW 0p0lHZ1GREDHycOKCXT0vxzKtIc9CFd92ttTZiJYwbqXfHyxGcncXue9nh/33HpIqKI= X-Gm-Gg: AYBFou2dCmwd+i5xj9CAhxluPeRVilGfwOu1HgE1kujkzcYNeC+nYudp0jg5g1Jq81G HhFUsfld+BbHj5wGtRYbI53dN+qFz5SYRmPOn2eIXXZBgH/vt7XUUyXj2+hPKUcGLg2CjiUpFl8 Aa4NQv4T7zJXazPA49qjFRY7St6ku0LUY95zSY0DHyD9a5dUve9lEmuwieesGFgk0HsFOnV49wV PrhXVpUXiBHRIzDj68+sl/YxUGSR8nzq/XEwNRLDmL8fgHO7phOp7zA6s032cDh7Rm+rZD/p1ZE 5s08lTXmTpV10LKYHEsLwC8h+oMIxiABDbJGxFGg3GyulBtCLEORKI+4yAXDl/jWC4/MvESFESW K3qmoD46UAT83MHM0I7KAPMOmYjf0gPa8Un4KDHp8+ZmMK7Qssj5492U+mkypwKwpqwYYxgC5QP C9/m8zG3pOufvfEYCaAciyHTo5oxm0mOGhbMkAAwrBwQJcke8pSxJKXhf9pke2n4xBKqggQ0EGK O7h1FE5wcj24V9bEVlNKrf1wpjOvtEedshAxmQSqRs9+ZRLA3ou+rXrEnPABbmELBRXjZ65HvOK ciHU9SANP7z9kccJTFRAA0fX+naj/yinUK9WpTzie8UEqbW8iMdd X-Received: by 2002:a17:90b:53c7:b0:3aa:412f:b0a7 with SMTP id 98e67ed59e1d1-3ae89559e5emr1988079a91.5.1793401892018; Fri, 30 Oct 2026 16:11:32 -0700 (PDT) Received: from smtpclient.apple ([187.15.154.221]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae845e71a7sm5455902a91.15.2026.10.30.16.11.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Oct 2026 16:11:30 -0700 (PDT) From: "Enji Cooper (yaneurabeya)" Message-Id: <47007CA5-E848-4A19-98BD-509397129F1A@gmail.com> Content-Type: multipart/signed; boundary="Apple-Mail=_34E73A43-6338-420F-BBB7-E31FEC3E72DA"; protocol="application/pgp-signature"; micalg=pgp-sha256 List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: Commit messages for all branches of the src repository List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.700.51.1.3\)) Subject: Re: git: 3fb03fb35b20 - main - [tests] switch GoogleTest tests to `googletest` interface Date: Fri, 30 Oct 2026 16:11:19 -0700 In-Reply-To: <89E29294-CBC3-4047-BDE1-8BF9BD978A09@gmail.com> Cc: Enji Cooper , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org To: Mark Johnston References: <6ae3d7a5.39b6a.63003bda@gitrepo.freebsd.org> <15E8ABE9-8E0C-4950-983A-FC429826890A@gmail.com> <89E29294-CBC3-4047-BDE1-8BF9BD978A09@gmail.com> X-Mailer: Apple Mail (2.3864.700.51.1.3) X-Rspamd-Queue-Id: 4jGcKz25d8z4l2y X-Spamd-Bar: -- X-Spamd-Result: default: False [-2.60 / 15.00]; SIGNED_PGP(-2.00)[]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4864::/56:c]; MIME_GOOD(-0.20)[multipart/signed,multipart/alternative,text/plain]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20260707]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+,3:~,4:~]; FROM_HAS_DN(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::52e:from]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; HAS_ATTACHMENT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] --Apple-Mail=_34E73A43-6338-420F-BBB7-E31FEC3E72DA Content-Type: multipart/alternative; boundary="Apple-Mail=_AE7B6C1D-1256-4C8A-B00C-DC9127614C23" --Apple-Mail=_AE7B6C1D-1256-4C8A-B00C-DC9127614C23 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Oct 30, 2026, at 2:59=E2=80=AFPM, Enji Cooper (yaneurabeya) = wrote: =E2=80=A6 > Well, some good news and bad news on this front. Good news: the tests = will be run as root again as well as unprivileged users (diff pending), = restoring test coverage. Bad news is that there will be =E2=80=9Ctest = result bloat=E2=80=9D: there=E2=80=99s no way to really get around the = fact that a ton of tests when run as an unprivileged user will be = skipped with the same message (=E2=80=9Crequires root=E2=80=9D). This = can be fixed with some light refactoring, but it=E2=80=99s not a simple = Makefile change like the (soon-to-be) proposed change will be. >=20 > Some of the other permutations previously allowed with capsicum-test = available in the larger test suite might need to be added (there are = additional arguments which support different behavior in = `capsicum-test-main.cc`), but this isn=E2=80=99t a regression since this = was the way things were prior to = 3fb03fb35b20d259e0a3a07fc48f2ecc3c5da6e8 . The only real net-change in = behavior in the tests is that functional.sh explicitly tested root and = non-root users and functional.sh ran the entire test suite, unlike kyua = does with googletest now (kyua runs each testcase in isolation, = process-wise). Review posted: https://reviews.freebsd.org/D61066 . -Enji= --Apple-Mail=_AE7B6C1D-1256-4C8A-B00C-DC9127614C23 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On= Oct 30, 2026, at 2:59=E2=80=AFPM, Enji Cooper (yaneurabeya) = <yaneurabeya@gmail.com> = wrote:

=E2=80=A6

Well, some good news and bad news on this = front. Good news: the tests will be run as root again as well as = unprivileged users (diff pending), restoring test coverage. Bad news is = that there will be =E2=80=9Ctest result bloat=E2=80=9D: there=E2=80=99s = no way to really get around the fact that a ton of tests when run as an = unprivileged user will be skipped with the same message (=E2=80=9Crequires= root=E2=80=9D). This can be fixed with some light refactoring, but = it=E2=80=99s not a simple Makefile change like the (soon-to-be) proposed = change will be.

Some of the other permutations previously allowed = with capsicum-test available in the larger test suite might need to be = added (there are additional arguments which support different behavior = in `capsicum-test-main.cc`), but this isn=E2=80=99t a regression since = this was the way things were prior to = 3fb03fb35b20d259e0a3a07fc48f2ecc3c5da6e8 . The only real net-change in = behavior in the tests is that functional.sh explicitly tested root and = non-root users and functional.sh ran the entire test suite, unlike kyua = does with googletest now (kyua runs each testcase in isolation, = process-wise).

-Enji
= --Apple-Mail=_AE7B6C1D-1256-4C8A-B00C-DC9127614C23-- --Apple-Mail=_34E73A43-6338-420F-BBB7-E31FEC3E72DA Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmrlJBcACgkQGpE5DjPs NJicIxAAnpuzCsiTtyGjhKhHWRst5/BcwjUsLMnKEP49J2Os8qhAAdjg6bMgkqGe Gf1jTiC05X8toOEuz+/x4VjUGE20xiXlTZ7kHbmyU3tMWz2uuE7F0Z3n7Ac30BPO ynZhJGaGDqGo2gDxNfITzoKbSxJ15ffoV8qQeQswpkHuMs54LyCUZYFdjMulT65M sne7u+URzoGAMa2lwPKRTWVe/gZ9k2c/X/DXC9hWk1M6hyzBeId3dKDg3JJMAvdo xR2eSqbQ/7ySs7vtUIqIA7SeTWmh5uST9G8vXzys35omN6pRHTMvtFaCvdipXFm0 QuEs73tYvXAun1IYKBm4gF8/VGBf2FuPf5VhU350UmKlmeEn7DZaU7Gt6uBeIHI/ BYdMWaiMj3W0bSH45eep1Ui1sq6cfsRW9NY499Q+dKEISKVyCixCXV4cWnbpAny4 hXjtLDn9ufRcwEl8D9CLHFCq6zr3ppaoyi7UCK8lpq20jNvb3/n4lMvRpMcLAvvc 5Z0wvSFqbnGcCw3S+SpZBh7BPkt8QN1mDdyn3Ykh4P+ScT3DuqwB5CWyXjbtFUfd aCMJFNpBc6KYjstfGpFA5isxT5+wiCcWdrwElNZGGjfhvMNBsPz6QNgP61c5eB6o pPV2u9tXDh7CMaypFZaZQf+WygqM6MecAF3Nj/KO/GBYqqMhMgg= =0Ija -----END PGP SIGNATURE----- --Apple-Mail=_34E73A43-6338-420F-BBB7-E31FEC3E72DA--